Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489567

[PATCH 01/15] perf evsel: Remove superfluous initialization of weight

Show all headers | View raw

From: Jiri Olsa <jolsa@kernel.org>

Removing superfluous initialization of weight, it's already set to 0 via
memset.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1474290610-23241-3-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evsel.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 21fd573106ed..f3225a2e6eee 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1728,7 +1728,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
 	data->cpu = data->pid = data->tid = -1;
 	data->stream_id = data->id = data->time = -1ULL;
 	data->period = evsel->attr.sample_period;
-	data->weight = 0;
 	data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
 
 	if (event->header.type != PERF_RECORD_SAMPLE) {
@@ -1935,7 +1934,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
 		}
 	}
 
-	data->weight = 0;
 	if (type & PERF_SAMPLE_WEIGHT) {
 		OVERFLOW_CHECK_u64(array);
 		data->weight = *array;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 02/15] perf hists: Use bigger buffer for stdio headers Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 07/15] perf tools: Add PMU configuration to tools Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 03/15] perf tools: Confine __get_cpuid() to x86 architecture Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 08/15] perf tools: Add sink configuration for cs_etm PMU Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 09/15] perf hists: Add __hist_entry__snprintf function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 04/15] perf tools: Make coresight PMU listable Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 01/15] perf evsel: Remove superfluous initialization of weight Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 14/15] perf hists: Make __hist_entry__snprintf function global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 13/15] perf tools: Make several display functions global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 12/15] perf tools: Make several sorting functions global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 11/15] perf tools: Make output_field_add and sort_dimension__add global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  [PATCH 06/15] perf pmu: Push configuration down to PMU driver Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 23:20 +0200
  Re: [GIT PULL 00/15] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2016-09-23 07:30 +0200

csiph-web