Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489516

Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue

Show all headers | View raw

On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Remove unnecessary braces surrounding a single statement block
>

In the future, when sending different versions of a patch please
give a short summary of what's changed. I think this is just
a resend from v2 with more reviewers added but I'm not 100%
sure.

> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---

You can put your summary right here between the --- and the
diffstat.

>  drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index 659aa71..bd45151 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
>
>  	ipdev = platform_get_drvdata(pdev);
>
> -	for (i = 0; i < ipdev->data->nr; i++) {
> +	for (i = 0; i < ipdev->data->nr; i++)
>  		ion_heap_destroy(ipdev->heaps[i]);
> -	}
> +
>  	ion_destroy_platform_data(ipdev->data);
>  	ion_device_destroy(ipdev->idev);
>
>

The patch looks fine though so assuming nothing else has
changed

Acked-by: Laura Abbott <labbott@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] staging: ion: Fix a coding style issue Antti Keränen <detegr@gmail.com> - 2016-09-22 18:10 +0200
  Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue Laura Abbott <labbott@redhat.com> - 2016-09-22 22:20 +0200

csiph-web