Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489371

Re: [PATCH 14/14] GPU-DRM-TTM: Mark an array of text strings as "const" in ttm_dma_pool_init()

Show all headers | View raw

On Thu, 2016-09-22 at 19:46 +0200, SF Markus Elfring wrote:
> The local variable "n" was not modified after it was initialized with
> a few text strings.
> Thus express this detail also by the data type qualifier "const".
[]
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
[]
> @@ -574,7 +574,7 @@ static int ttm_dma_pool_match(struct device *dev, void *res, void *match_data)
>  static struct dma_pool *ttm_dma_pool_init(struct device *dev, gfp_t flags,
>  					  enum pool_type type)
>  {
> -	char *n[] = {"wc", "uc", "cached", " dma32", "unknown",};
> +	char const * const n[] = {"wc", "uc", "cached", " dma32", "unknown",};
>  	enum pool_type t[] = {IS_WC, IS_UC, IS_CACHED, IS_DMA32, IS_UNDEFINED};


Please think a little deeper about what you are changing here
and look at the line immediately below it too.

Both should be static const to avoid unnecessary reload.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 14/14] GPU-DRM-TTM: Mark an array of text strings as "const"  in ttm_dma_pool_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 20:40 +0200
  Re: [PATCH 14/14] GPU-DRM-TTM: Mark an array of text strings as  "const" in ttm_dma_pool_init() Joe Perches <joe@perches.com> - 2016-09-22 20:50 +0200

csiph-web