Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: wlan-ng: fixed a coding style issue
Date	2016-09-22 20:30 +0200
Message-ID	<skgUW-1qI-23@gated-at.bofh.it> (permalink)
References	<skgBz-1j2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-09-22 at 20:01 +0200, Jannik Becher wrote:
> changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding
> style.

Hello.

Please always use Greg KH's latest staging-next branch (or -next)
to make these sorts of changes.  This one has already been done.

https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/
$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
$ cd staging
$ git checkout staging-next

> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
[]
> @@ -305,7 +305,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>  
>  	memset(sinfo, 0, sizeof(*sinfo));
>  
> -	if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
> +	if ((!wlandev) || (wlandev->msdstate != WLAN_MSD_RUNNING))

And it might be nicer without the unnecessary parentheses too

	if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: wlan-ng: fixed a coding style issue Jannik Becher <becher.jannik@gmail.com> - 2016-09-22 20:10 +0200
  Re: [PATCH] drivers: wlan-ng: fixed a coding style issue Joe Perches <joe@perches.com> - 2016-09-22 20:30 +0200

csiph-web