Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489143

Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset latency

Show all headers | View raw

Binoy,

On Thu, 22 Sep 2016, Binoy Jayan wrote:
> The condition 'ktime_to_ns(tim) < ktime_to_ns(now)' checks if the timer
> has already expired w.r.t. 'soft timeout' value as it does not include
> the slack value 'delta_ns'. In that case 'tim_expiry' is normalized to
> the current time.

You are halfways coming close to the point why this is done, but your
conclusion is completely wrong.  The correct keyword is "expired", but
anything else is just random speculation.

> (I was under the impression that this inaccuracy
> could be because timer was initially running on a different cpu. If that
> is not the case, I guess we can use the code mentioned below).

We are not playing a guessing game here.
 
> I am using 'hrtimer_get_softexpires_tv64' instead of 'hrtimer_get_expires'
> so that 'latency' is never negative. Please let me know if this looks ok.

No it does not. And it won't look correct until you finally sit down and
decode and understand the functionality behind this code.

I'm not going to continue this, as it's not my job to explain you the code
which you are trying to submit.

I'm not blaming you, but I blame the responsible persons inside your
company who task you with that and expect that I'm going to do their work
of explaining to you how that code works.

@Arnd, @Mark: I'm starting to get seriously grumpy about that.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v7 0/5] *** Latency histograms *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-20 16:00 +0200
  [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset latency Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-20 16:00 +0200
    Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset  latency Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 16:30 +0200
      Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset latency Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-21 08:10 +0200
        Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset  latency Thomas Gleixner <tglx@linutronix.de> - 2016-09-21 18:10 +0200
          Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset latency Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-22 11:20 +0200
            Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset  latency Thomas Gleixner <tglx@linutronix.de> - 2016-09-22 19:40 +0200
              Re: [RFC PATCH v7 4/5] tracing: Measure delayed hrtimer offset  latency Mark Brown <broonie@kernel.org> - 2016-09-22 21:30 +0200
  [RFC PATCH v7 2/5] tracing: Add hist trigger support for generic fields Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-20 16:00 +0200
  [RFC PATCH v7 5/5] tracing: wakeup latency events and histograms Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-20 16:00 +0200
  [RFC PATCH v7 3/5] tracing: Add preemptirqsoff timing events Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-20 16:00 +0200
  [RFC PATCH v7 1/5] tracing: Dereference pointers without RCU checks Binoy Jayan <binoy.jayan@linaro.org> - 2016-09-20 16:00 +0200

csiph-web