Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489107

Re: [patch v5] x86/platform/mellanox: introduce support for Mellanox systems platform

Show all headers | View raw

On Tue, 20 Sep 2016, vadimp@mellanox.com wrote:

Just a few nitpicks.

> +/* Regions for LPC I2C controller and LPC base register space */
> +static struct resource mlxplat_lpc_resources[] = {

Shouldnt this be const?

> +static int mlxplat_default_channels[][8] = {
> +	{

Ditto. And some more of these?

> +static struct dmi_system_id mlxplat_dmi_table[] __initdata = {

This one as well.

> +static int __init mlxplat_init(void)
> +{
> +	struct mlxplat_priv *priv;
> +	int i;
> +	int err;

Same types can go into one line.

> +
> +	return err;

err is unitialized if we get here. Just return 0 and be done with it.
> +
> +fail_platform_mux_register:

> +static void __exit mlxplat_exit(void)
> +{
> +	struct mlxplat_priv *priv = platform_get_drvdata(mlxplat_dev);
> +	int i;
> +
> +	for (i = ARRAY_SIZE(mlxplat_mux_data) - 1; i >= 0 ; i--)
> +		platform_device_unregister(priv->pdev_mux[i]);
> +
> +	platform_device_unregister(priv->pdev_i2c);
> +	platform_device_unregister(mlxplat_dev);
> +}
> +
> +module_init(mlxplat_init);
> +module_exit(mlxplat_exit);

Please move the module_xxx() right under the closing brace of the function
to which it belongs.

Otherwise this looks good.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch v5] x86/platform/mellanox: introduce support for Mellanox systems platform vadimp@mellanox.com - 2016-09-20 10:10 +0200
  Re: [patch v5] x86/platform/mellanox: introduce support for Mellanox  systems platform Thomas Gleixner <tglx@linutronix.de> - 2016-09-22 19:20 +0200

csiph-web