Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1489005
| From | Jiri Olsa <jolsa@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 01/57] perf tools: Add __hist_entry__snprintf function |
| Date | 2016-09-22 17:40 +0200 |
| Message-ID | <skegr-8a2-47@gated-at.bofh.it> (permalink) |
| References | <skegp-8a2-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Add __hist_entry__snprintf to take perf_hpp_list as an argument
instead of using he->hists->hpp_list. This way we can display
arbitrary list of entries regardles of the hists setup, which
will be useful in following patches.
Link: http://lkml.kernel.org/n/tip-j2sizkyglam3narmndlj99xq@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/ui/stdio/hist.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
index c8dca34585ea..189665c315cc 100644
--- a/tools/perf/ui/stdio/hist.c
+++ b/tools/perf/ui/stdio/hist.c
@@ -373,7 +373,8 @@ static size_t hist_entry_callchain__fprintf(struct hist_entry *he,
return 0;
}
-static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
+static int __hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp,
+ struct perf_hpp_list *hpp_list)
{
const char *sep = symbol_conf.field_sep;
struct perf_hpp_fmt *fmt;
@@ -384,7 +385,7 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
if (symbol_conf.exclude_other && !he->parent)
return 0;
- hists__for_each_format(he->hists, fmt) {
+ perf_hpp_list__for_each_format(hpp_list, fmt) {
if (perf_hpp__should_skip(fmt, he->hists))
continue;
@@ -410,6 +411,11 @@ static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
return hpp->buf - start;
}
+static int hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp)
+{
+ return __hist_entry__snprintf(he, hpp, he->hists->hpp_list);
+}
+
static int hist_entry__hierarchy_fprintf(struct hist_entry *he,
struct perf_hpp *hpp,
struct hists *hists,
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv4 00/57] perf c2c: Add new tool to analyze cacheline contention on NUMA systems Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:40 +0200
[PATCH 01/57] perf tools: Add __hist_entry__snprintf function Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:40 +0200
Re: [PATCH 01/57] perf tools: Add __hist_entry__snprintf function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 18:00 +0200
[tip:perf/core] perf hists: Add __hist_entry__snprintf function tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
[PATCH 43/57] perf c2c report: Add main browser Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:40 +0200
[PATCH 21/57] perf c2c report: Add offset dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:40 +0200
[PATCH 55/57] perf c2c report: Iterate node display in browser Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:40 +0200
[PATCH 41/57] perf c2c report: Set final resort fields Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 23/57] perf c2c report: Add hitm related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 51/57] perf c2c report: Allow to set cacheline sort fields Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 39/57] perf c2c report: Add src line sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 44/57] perf c2c report: Add cacheline browser Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 30/57] perf c2c report: Add hitm percent sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 42/57] perf c2c report: Add stdio output support Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 53/57] perf c2c report: Add cacheline index entry Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 47/57] perf c2c report: Add c2c related stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 24/57] perf c2c report: Add stores related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 56/57] perf c2c report: Add help windows Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 31/57] perf c2c report: Add hitm/store percent related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 22/57] perf c2c report: Add iaddr dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 33/57] perf c2c report: Add pid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 49/57] perf c2c report: Limit the cachelines table entries Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 28/57] perf c2c report: Add total record sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 26/57] perf c2c report: Add llc and remote loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 34/57] perf c2c report: Add tid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 25/57] perf c2c report: Add loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 37/57] perf c2c report: Add stats related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 50/57] perf c2c report: Add support to choose local HITMs Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 36/57] perf c2c report: Add node sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 45/57] perf c2c report: Add global stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 52/57] perf c2c report: Recalc width of global sort entries Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 38/57] perf c2c report: Add cpu cnt sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:50 +0200
[PATCH 08/57] perf tools: Make __hist_entry__snprintf function global Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
Re: [PATCH 08/57] perf tools: Make __hist_entry__snprintf function global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 18:00 +0200
[tip:perf/core] perf hists: Make __hist_entry__snprintf function global tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:40 +0200
[PATCH 06/57] perf tools: Make several sorting functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
Re: [PATCH 06/57] perf tools: Make several sorting functions global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 18:00 +0200
[tip:perf/core] perf tools: Make several sorting functions global tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:40 +0200
[PATCH 19/57] perf c2c report: Add header macros Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
Re: [PATCH 04/57] perf tools: Make reset_dimensions global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 03/57] perf tools: Introduce c2c_add_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 11/57] perf c2c: Add record subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 04/57] perf tools: Make reset_dimensions global Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[tip:perf/core] perf tools: Make reset_dimensions global tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
[PATCH 17/57] perf c2c report: Add cacheline hists processing Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 14/57] perf c2c report: Add sort_entry dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 09/57] perf tools: Make hists__fprintf_headers function global Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
Re: [PATCH 09/57] perf tools: Make hists__fprintf_headers function global Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-22 18:00 +0200
[tip:perf/core] perf hists: Make hists__fprintf_headers function global tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:40 +0200
[PATCH 15/57] perf c2c report: Fallback to standard dimensions Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 10/57] perf c2c: Add c2c command Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
[PATCH 12/57] perf c2c: Add report subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-22 18:00 +0200
csiph-web