Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488990

[PATCH 32/57] perf c2c report: Add dram related sort keys

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Jiri Olsa <jolsa@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 32/57] perf c2c report: Add dram related sort keys
Date Thu, 22 Sep 2016 17:40:01 +0200
Message-ID <skegp-8a2-5@gated-at.bofh.it> (permalink)
References <skegp-8a2-3@gated-at.bofh.it>
X-Scanned-By MIMEDefang 2.68 on 10.5.11.26
X-Greylist Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 22 Sep 2016 15:38:41 +0000 (UTC)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 64
Organization linux.* mail to news gateway
X-Original-Cc lkml <linux-kernel@vger.kernel.org>, Don Zickus <dzickus@redhat.com>, Joe Mario <jmario@redhat.com>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
X-Original-Date Thu, 22 Sep 2016 17:37:00 +0200
X-Original-Message-ID <1474558645-19956-33-git-send-email-jolsa@kernel.org>
X-Original-References <1474558645-19956-1-git-send-email-jolsa@kernel.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1488990

Show key headers only | View raw


Adding dram related dimension key wrappers.

They are to be displayed in the main cachelines
overall output:

  dram_lcl, dram_rmt

They display DRAM rmt/lcl access numbers for
specific cacheline.

Link: http://lkml.kernel.org/n/tip-tl3qqi9ehk6g1fla4z7y0ykd@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/builtin-c2c.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index b2992cf96130..030a33a93caf 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -804,6 +804,9 @@ percent_stores_l1miss_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
 	return per_left - per_right;
 }
 
+STAT_FN(lcl_dram)
+STAT_FN(rmt_dram)
+
 #define HEADER_LOW(__h)			\
 	{				\
 		.line[1] = {		\
@@ -1052,6 +1055,22 @@ static struct c2c_dimension dim_percent_stores_l1miss = {
 	.width		= 7,
 };
 
+static struct c2c_dimension dim_dram_lcl = {
+	.header		= HEADER_SPAN("--- Load Dram ----", "Lcl", 1),
+	.name		= "dram_lcl",
+	.cmp		= lcl_dram_cmp,
+	.entry		= lcl_dram_entry,
+	.width		= 8,
+};
+
+static struct c2c_dimension dim_dram_rmt = {
+	.header		= HEADER_SPAN_LOW("Rmt"),
+	.name		= "dram_rmt",
+	.cmp		= rmt_dram_cmp,
+	.entry		= rmt_dram_entry,
+	.width		= 8,
+};
+
 static struct c2c_dimension *dimensions[] = {
 	&dim_dcacheline,
 	&dim_offset,
@@ -1079,6 +1098,8 @@ static struct c2c_dimension *dimensions[] = {
 	&dim_percent_lcl_hitm,
 	&dim_percent_stores_l1hit,
 	&dim_percent_stores_l1miss,
+	&dim_dram_lcl,
+	&dim_dram_rmt,
 	NULL,
 };
 
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 32/57] perf c2c report: Add dram related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-22 17:40 +0200

csiph-web