Re: [PATCH] drm/tilcdc: mark tilcdc_atomic_check() static

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jyri Sarha <jsarha@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/tilcdc: mark tilcdc_atomic_check() static
Date	Thu, 22 Sep 2016 18:10:01 +0200
Message-ID	<skeJr-7S-1@gated-at.bofh.it> (permalink)
References	<sjI6R-4LT-1@gated-at.bofh.it>
X-Original-To	Baoyou Xie <baoyou.xie@linaro.org>, <tomi.valkeinen@ti.com>, <airlied@linux.ie>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>, <arnd@arndb.de>, <xie.baoyou@zte.com.cn>
X-Original-Date	Thu, 22 Sep 2016 19:01:44 +0300
X-Original-Message-ID	<199cb69f-fab1-d202-5ee8-70665217c66d@ti.com>
X-Original-References	<1474434876-9293-1-git-send-email-baoyou.xie@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1489064

Show key headers only | View raw

Thank,
But I already have this too:
http://www.spinics.net/lists/kernel/msg2340400.html

Best regards,
Jyri

On 09/21/16 08:14, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for 'tilcdc_atomic_check' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..1d26bc9 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,7 +61,7 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
>  	drm_fbdev_cma_hotplug_event(priv->fbdev);
>  }
>  
> -int tilcdc_atomic_check(struct drm_device *dev,
> +static int tilcdc_atomic_check(struct drm_device *dev,
>  			struct drm_atomic_state *state)
>  {
>  	int ret;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/tilcdc: mark tilcdc_atomic_check() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-21 07:20 +0200
  Re: [PATCH] drm/tilcdc: mark tilcdc_atomic_check() static Jyri Sarha <jsarha@ti.com> - 2016-09-22 18:10 +0200

csiph-web