Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488929

[PATCH] clocksource: timer-digicolor: Unmap region obtained by of_iomap

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] clocksource: timer-digicolor: Unmap region obtained by of_iomap
Date Thu, 22 Sep 2016 16:30:01 +0200
Message-ID <skdaF-7wd-1@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=AOzxcNUuxF5ZhQb3MOmjPoghfVH4KSJ/aWNQ9uqiQ7s=; b=JAZb1Vn7DcbmK0kaL13ozrctZzEKQb7yaPhYhqLWPgqrlBNFA1rdR3Q/y49lEHzia+ j/029ONxqwknb6MDBEZrZxN02O0MmNMy9iIL0I6nY6ouaCpAifWubuxaWvHOuOnIOEKc x+VFNldVZ1SZbH25fbNF8hqoVMEMBq4Xj5rXIu7PlUwaT2kPglj6hrvdVGtkCiFq8Djr xe/FCfY65DpneJ9Nrxpun2MuQY0gqZXCbOd8CP2ogozUTPjUe5lPBoPWEzZ876WNQSid 6AAZP3kuTY9wW/v6OMz9QZGOv4IohNWpkJOsv4esDsU4RiW3nQuYH5ZtmtiEjUl/lE2e 12Cw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AOzxcNUuxF5ZhQb3MOmjPoghfVH4KSJ/aWNQ9uqiQ7s=; b=baHKPmXSVf6KiEqaEIqL0qcqP8IRSZHMUzunKUqmRbruEQk9CAG78gGzDAoksmpAYU kcR/njJswL8Qv0AUkLJtGVazHYc8Qt6SEWn1O7Ob4PyI2gJJATfyK8fTFYqdSz0tNMPs 9Mypf6RIp/3cn/BtAPQF852ozstGiu121s8c6EPxxKgN8+rryb9DEHS4RG0uRWb8CDok Bj6H/3j8a1IzO/gl9X1Zhr6R6zpUnLjeyFpXyR4so9RFG0bugnS3xlzsGO388s6ifWJz z1KCNknUpk27Dyp1+2t28TEJ0xmz/8KwXZPeHIyEmuo3uEAJGo80r7cwRDkDBFGo5F0T HH/A==
X-Gm-Message-State AE9vXwN5aPCwMcCihpYyhri5CNFEwSKODPu6YHTEeQ6c6DpmrJWh8/zupYdxsAcV4aWjfg==
X-Received by 10.66.156.196 with SMTP id wg4mr3703171pab.153.1474554106543; Thu, 22 Sep 2016 07:21:46 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date Thu, 22 Sep 2016 19:51:13 +0530
X-Original-Message-ID <1474554073-8658-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1488929

Show key headers only | View raw


Free memory mapping, if digicolor_timer_init is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/clocksource/timer-digicolor.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
index 10318cc..e6e5e6a 100644
--- a/drivers/clocksource/timer-digicolor.c
+++ b/drivers/clocksource/timer-digicolor.c
@@ -167,12 +167,14 @@ static int __init digicolor_timer_init(struct device_node *node)
 	irq = irq_of_parse_and_map(node, dc_timer_dev.timer_id);
 	if (irq <= 0) {
 		pr_err("Can't parse IRQ");
+		iounmap(dc_timer_dev.base);
 		return -EINVAL;
 	}
 
 	clk = of_clk_get(node, 0);
 	if (IS_ERR(clk)) {
 		pr_err("Can't get timer clock");
+		iounmap(dc_timer_dev.base);
 		return PTR_ERR(clk);
 	}
 	clk_prepare_enable(clk);
@@ -192,6 +194,7 @@ static int __init digicolor_timer_init(struct device_node *node)
 			  &dc_timer_dev.ce);
 	if (ret) {
 		pr_warn("request of timer irq %d failed (%d)\n", irq, ret);
+		iounmap(dc_timer_dev.base);
 		return ret;
 	}
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] clocksource: timer-digicolor: Unmap region obtained by of_iomap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-22 16:30 +0200
  Re: [PATCH] clocksource: timer-digicolor: Unmap region obtained by  of_iomap Baruch Siach <baruch@tkos.co.il> - 2016-09-22 16:50 +0200

csiph-web