Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes

From	Kim Phillips <kim.phillips@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes
Date	2016-09-22 17:00 +0200
Message-ID	<skdDH-7GI-5@gated-at.bofh.it> (permalink)
References	<sjS6d-2q3-3@gated-at.bofh.it> <sjVx8-4Eu-41@gated-at.bofh.it> <sk4Ap-2ay-3@gated-at.bofh.it>
Organization	ARM

Show all headers | View raw

On Thu, 22 Sep 2016 10:48:13 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> On Thursday 22 September 2016 01:04 AM, Kim Phillips wrote:
> > On Wed, 21 Sep 2016 21:17:50 +0530
> > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> >
> >> Kim, I don't have arm test machine. Can you please help me to test
> >> this on arm.
> > This works for me:  hitting return on return instructions yields
> > "Invalid jump offset", but I'll get that later.
> 
> Thanks Kim.
> 
> Hmm.. so, ins__find_arm does not contain logic for return instructions. Navigation
> with return instruction is working fine for x86 and powerpc.

Right, for ARM, in order to match return instructions, 'lr' must be
found to be the operand of the branch instruction, which is not
contained in the 'name' variable passed to ins__find().

I don't want this to inhibit acceptance of this series, however: I plan
on addressing it afterwards, unless, of course, it is perceived as a
problem somehow (compatibility-wise, it is not because it is an error
at the moment).

Thanks,

Kim

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/6] perf annotate: Cross arch support + few fixes Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-09-21 18:00 +0200
  [PATCH v7 2/6] perf annotate: Add support for powerpc Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-09-21 18:00 +0200
  [PATCH v7 1/6] perf annotate: Add cross arch annotate support Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-09-21 18:00 +0200
  Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes Kim Phillips <kim.phillips@arm.com> - 2016-09-21 21:40 +0200
    Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-09-22 07:20 +0200
      Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes Kim Phillips <kim.phillips@arm.com> - 2016-09-22 17:00 +0200

csiph-web