Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488992

RE: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver

Show all headers | View raw

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, September 22, 2016 3:31 PM
> To: Vadim Pasternak <vadimp@mellanox.com>
> Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org;
> akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org;
> linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver-
> x86@vger.kernel.org; jiri@resnulli.us
> Subject: Re: [patch v1] drivers/platform/x86: introduce support for Mellanox
> hotplug driver
> 
> On Thu, Sep 22, 2016 at 01:14:27PM +0000, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Enable system support for the Mellanox Technologies hotplug platform
> > driver, which provides support for the next Mellanox basic systems:
> > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
> > "msb7800", "msn2740", "msn2100" and also various number of derivative
> > systems from the above basic types.
> > This driver handles hot-plug events for the power suppliers, power
> > cables and fans for the above systems.
> >
> > The Kconfig currently controlling compilation of this code is:
> > driver/platform/x86:config MLX_CPLD_PLATFORM
> >                        tristate "Mellanox platform hotplug driver support"
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> >  MAINTAINERS                                   |   7 +
> >  drivers/platform/x86/Kconfig                  |  10 +
> >  drivers/platform/x86/Makefile                 |   1 +
> >  drivers/platform/x86/mlxcpld-hotplug.c        | 543
> ++++++++++++++++++++++++++
> >  include/linux/platform_data/mlxcpld-hotplug.h |  90 +++++
> 
> Why do you need a platform_data .h file for a stand-alone driver?
> 

I have another module mlx-platform, which is reviewed now (I also got a number feedbacks from you on this matter).
I want to activate mlxcpld-hotplug from this module. 
Like

/* Platform hotplug default data */
static struct mlxcpld_hotplug_platform_data mlxplat_mlxcpld_hotplug_default_data = {
 
/* Platform hotplug MSN21xx system family data*/
static struct mlxcpld_hotplug_platform_data mlxplat_mlxcpld_hotplug_msn21xx_data = {
...
	priv->pdev_hotplug = platform_device_register_resndata(
				&mlxplat_dev->dev, "mlxcpld-hotplug", -1,
				mlxplat_mlxcpld_hotplug_resources,
				ARRAY_SIZE(mlxplat_mlxcpld_hotplug_resources),
				mlxplat_hotplug, sizeof(*mlxplat_hotplug));

But I can't add this code to mlx-platfrom, until this one is not accepted.

Thanks,

Vadim.

> thanks,
> 
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver vadimp@mellanox.com - 2016-09-22 13:20 +0200
  Re: [patch v1] drivers/platform/x86: introduce support for Mellanox  hotplug driver Greg KH <gregkh@linuxfoundation.org> - 2016-09-22 14:40 +0200
    Re: [patch v1] drivers/platform/x86: introduce support for Mellanox  hotplug driver Greg KH <gregkh@linuxfoundation.org> - 2016-09-22 15:50 +0200
      RE: [patch v1] drivers/platform/x86: introduce support for Mellanox  hotplug driver Vadim Pasternak <vadimp@mellanox.com> - 2016-09-22 16:00 +0200
      Re: [patch v1] drivers/platform/x86: introduce support for Mellanox  hotplug driver Greg KH <gregkh@linuxfoundation.org> - 2016-09-22 16:00 +0200
      RE: [patch v1] drivers/platform/x86: introduce support for Mellanox  hotplug driver Vadim Pasternak <vadimp@mellanox.com> - 2016-09-22 16:10 +0200
    RE: [patch v1] drivers/platform/x86: introduce support for Mellanox  hotplug driver Vadim Pasternak <vadimp@mellanox.com> - 2016-09-22 17:40 +0200

csiph-web