Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488882

Re: [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs

From Leon Romanovsky <leon@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs
Date 2016-09-22 15:40 +0200
Message-ID <skcoh-6Y0-13@gated-at.bofh.it> (permalink)
References <sjvMm-5fH-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 20, 2016 at 05:06:53PM +0100, Salil Mehta wrote:
> This patch-set introduces fixes for various bugs and potential
> problems found during internal review and testing phases of
> the HNS RoCE driver.
>
> NOTE: These fixes have been done over already floated CM
> patch: https://lkml.org/lkml/2016/9/1/609
>
> All fixes have been done & tested by Oulijun and Huwei.
>
> V1->V2: * PATCH 3/20 and 13/20 have been dropped after rework
>           of comments by Leon Romanovsky on V1 patch.
>         * New patch "Fix for removal of redundant code" has
>           been added to remove the redundant code.
>
> Lijun Ou (15):
>   IB/hns: Remove unused parameters in some functions
>   IB/hns: Remove parameters of resize cq
>   IB/hns: Fix bug of using uninit refcount and free
>   IB/hns: Simplify function of pd alloc and qp alloc
>   IB/hns: Remove unused parameter named qp_type
>   IB/hns: Modify the init of iboe lock
>   IB/hns: Fix bug of memory leakage for registering user mr
>   IB/hns: Return bad wr while post send failed
>   IB/hns: The Ack timeout need a lower limit value
>   IB/hns: Some items of qpc need to take user param
>   IB/hns: Validate mtu when modified qp
>   IB/hns: Cq has not been freed
>   IB/hns: Update the rq head when modify qp state
>   IB/hns: Fix the bug when platform_get_resource() exec fail
>   IB/hns: Delete the redundant lines in hns_roce_v1_m_qp()
>
> Salil Mehta (1):
>   IB/hns: Fix for removal of redundant code
>
> Wei Hu (Xavier) (3):
>   IB/hns: Fix bug of clear hem
>   IB/hns: Delete the sqp_start from the structure hns_roce_caps
>   IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug
>     of qpn
>
>  drivers/infiniband/hw/hns/hns_roce_cq.c     |  23 +--
>  drivers/infiniband/hw/hns/hns_roce_device.h |  13 +-
>  drivers/infiniband/hw/hns/hns_roce_eq.c     | 146 ++++++++++---------
>  drivers/infiniband/hw/hns/hns_roce_eq.h     |   4 +
>  drivers/infiniband/hw/hns/hns_roce_hem.c    |  76 +---------
>  drivers/infiniband/hw/hns/hns_roce_hem.h    |   4 +
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c  | 211 +++++++++++++++++++++++-----
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.h  |   9 ++
>  drivers/infiniband/hw/hns/hns_roce_main.c   |   4 +-
>  drivers/infiniband/hw/hns/hns_roce_mr.c     |   3 +
>  drivers/infiniband/hw/hns/hns_roce_pd.c     |  18 +--
>  drivers/infiniband/hw/hns/hns_roce_qp.c     |  57 +++-----
>  12 files changed, 312 insertions(+), 256 deletions(-)

Thanks Salil,
The change from v0 to v2 is astonishing !!!!!!

Reviewed-by: Leon Romanovsky <leonro@mellanox.com> for whole series.

>
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:10 +0200
  [PATCH V2 for-next 05/19] IB/hns: Remove unused parameter named qp_type Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:10 +0200
  [PATCH V2 for-next 03/19] IB/hns: Fix bug of using uninit refcount and free Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:10 +0200
  [PATCH V2 for-next 06/19] IB/hns: Fix bug of clear hem Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:10 +0200
  [PATCH V2 for-next 11/19] IB/hns: Return bad wr while post send failed Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 13/19] IB/hns: Some items of qpc need to take user param Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 17/19] IB/hns: Fix the bug when platform_get_resource() exec fail Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 18/19] IB/hns: Delete the redundant lines in hns_roce_v1_m_qp() Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 12/19] IB/hns: The Ack timeout need a lower limit value Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 16/19] IB/hns: Update the rq head when modify qp state Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 10/19] IB/hns: Fix bug of memory leakage for registering user mr Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 02/19] IB/hns: Remove parameters of resize cq Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 01/19] IB/hns: Remove unused parameters in some functions Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 19/19] IB/hns: Fix for removal of redundant code Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 15/19] IB/hns: Cq has not been freed Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  [PATCH V2 for-next 14/19] IB/hns: Validate mtu when modified qp Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 18:20 +0200
  Re: [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs Leon Romanovsky <leon@kernel.org> - 2016-09-22 15:40 +0200

csiph-web