Re: [PATCH] ipvlan: fix building without netfilter

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ipvlan: fix building without netfilter
Date	2016-09-22 15:00 +0200
Message-ID	<skbLz-6w3-1@gated-at.bofh.it> (permalink)
References	<sk8NH-4AG-13@gated-at.bofh.it> <skbse-6le-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday, September 22, 2016 8:32:05 AM CEST David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Thu, 22 Sep 2016 11:40:52 +0200
> 
> > The new l3s mode in ipvlan relies on netfilter interfaces, but
> > the ipvlan driver can be configured when CONFIG_NETFILTER is disabled,
> > leading to a build error:
> > 
> > drivers/net/ipvlan/ipvlan.h:132:22: error: 'struct nf_hook_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > drivers/net/ipvlan/ipvlan_main.c:14:27: error: array type has incomplete element type 'struct nf_hook_ops'
> > ...
> > 
> > This adds a forward declaration for struct nf_hook_state, and hides
> > the newly added l3s code in an #ifdef.
> > 
> > Fixes: 4fbae7d83c98 ("ipvlan: Introduce l3s mode")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I'm pretty sure I applied a Kconfig patch that added the
> necessary dependency.

Yes, I see the fix cf714ac147e0 ("ipvlan: Fix dependency issue") now, and
can confirm that today's linux-next works without my patch, thanks!

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ipvlan: fix building without netfilter Arnd Bergmann <arnd@arndb.de> - 2016-09-22 11:50 +0200
  Re: [PATCH] ipvlan: fix building without netfilter David Miller <davem@davemloft.net> - 2016-09-22 14:40 +0200
    Re: [PATCH] ipvlan: fix building without netfilter Arnd Bergmann <arnd@arndb.de> - 2016-09-22 15:00 +0200

csiph-web