[PATCH 2/2] mfd: ab8500-debugfs: remove unused function

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Baoyou Xie <baoyou.xie@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] mfd: ab8500-debugfs: remove unused function
Date	Sat, 24 Sep 2016 07:40:01 +0200
Message-ID	<skNQR-5pm-3@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=u77sED1EkgbHENUBRgtLGg5EjalTCbfEUHY7CfIwTmY=; b=RGjnmYwHQX6yj0PPeOoNEk44KsAkk3+kces2TQUQyET3B9Q0n/lGEL16Sts+eC9AHK LnMjWqeo9ro5iHY8PnW/+pydeJdmfWYSezRKhwxmmaCJflPN2woQBIpgPKFYYO3FtOxE ug8tKRsxsKV2q0N8O0LJEiUiSsoiINPm1qOpE=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u77sED1EkgbHENUBRgtLGg5EjalTCbfEUHY7CfIwTmY=; b=WqSlnJrpWpSuAgo6aUbaCGWVaeUwYm8L+tXmniLRCX1XYNFG1tUJYPyKT76NiCmNmy dLj8c/11w1zn4sh0omv5wBK0/KaY/U2qwyjlOztX3cAANv5k7t77EBqz8lJE2BdolvLa B24bMw3ADV3gapV/EGBVlzPbBahIMoBQ4/mufomal93bWSyxp+XOLxuQ9lBfBnFfVG5O hOxYrVFw/MJH07XbkJh7lujQGlfsUrGNHujEc6KJetnvx8qIcdFqq9Yzw7fVWYtr7Ma6 uP8Wi3wQX+D/YZrHlABp5rd6//xVSyG6MfyZ+3RWHgeL3rRDa7tgXJ38N5uXqwqZYEGn 0G+w==
X-Gm-Message-State	AE9vXwNcZb+bJ4tvd0oz7WA0wLeq79cIcwC/Bsu2KJNtbNVSeORDBGo8XExvqxRshzjnyLST
X-Received	by 10.66.48.8 with SMTP id h8mr18835135pan.92.1474695425427; Fri, 23 Sep 2016 22:37:05 -0700 (PDT)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	78
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn
X-Original-Date	Sat, 24 Sep 2016 13:36:53 +0800
X-Original-Message-ID	<1474695413-30460-1-git-send-email-baoyou.xie@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1490562

Show key headers only | View raw

We get 1 warning when building kernel with W=1:
drivers/mfd/ab8500-debugfs.c:1395:6: warning: no previous prototype for 'ab8500_dump_all_banks_to_mem' [-Wmissing-prototypes]

In fact, this function is called by no one and not exported,
so this patch removes it.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/mfd/ab8500-debugfs.c | 54 --------------------------------------------
 1 file changed, 54 deletions(-)

diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 0aecd7b..9f04a25 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -1382,60 +1382,6 @@ void ab8500_dump_all_banks(struct device *dev)
 	}
 }
 
-/* Space for 500 registers. */
-#define DUMP_MAX_REGS 700
-static struct ab8500_register_dump
-{
-	u8 bank;
-	u8 reg;
-	u8 value;
-} ab8500_complete_register_dump[DUMP_MAX_REGS];
-
-/* This shall only be called upon kernel panic! */
-void ab8500_dump_all_banks_to_mem(void)
-{
-	int i, r = 0;
-	u8 bank;
-	int err = 0;
-
-	pr_info("Saving all ABB registers for crash analysis.\n");
-
-	for (bank = 0; bank < AB8500_NUM_BANKS; bank++) {
-		for (i = 0; i < debug_ranges[bank].num_ranges; i++) {
-			u8 reg;
-
-			for (reg = debug_ranges[bank].range[i].first;
-			     reg <= debug_ranges[bank].range[i].last;
-			     reg++) {
-				u8 value;
-
-				err = prcmu_abb_read(bank, reg, &value, 1);
-
-				if (err < 0)
-					goto out;
-
-				ab8500_complete_register_dump[r].bank = bank;
-				ab8500_complete_register_dump[r].reg = reg;
-				ab8500_complete_register_dump[r].value = value;
-
-				r++;
-
-				if (r >= DUMP_MAX_REGS) {
-					pr_err("%s: too many register to dump!\n",
-						__func__);
-					err = -EINVAL;
-					goto out;
-				}
-			}
-		}
-	}
-out:
-	if (err >= 0)
-		pr_info("Saved all ABB registers.\n");
-	else
-		pr_info("Failed to save all ABB registers.\n");
-}
-
 static int ab8500_all_banks_open(struct inode *inode, struct file *file)
 {
 	struct seq_file *s;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mfd: ab8500-debugfs: remove unused function Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 07:40 +0200
  Re: [PATCH 2/2] mfd: ab8500-debugfs: remove unused function Linus Walleij <linus.walleij@linaro.org> - 2016-10-04 14:20 +0200
  Re: [PATCH 2/2] mfd: ab8500-debugfs: remove unused function Lee Jones <lee.jones@linaro.org> - 2016-10-04 16:40 +0200

csiph-web