Re: [PATCH v2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels
Date	2016-09-24 02:00 +0200
Message-ID	<skIxP-1VY-1@gated-at.bofh.it> (permalink)
References	<skCC5-6Ov-9@gated-at.bofh.it> <skCC5-6Ov-7@gated-at.bofh.it> <skIxP-1VY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 23, 2016 at 4:39 PM, Peter Rosin <peda@axentia.se> wrote:
> On 2016-09-23 19:39, Rob Herring wrote:
>> On Sat, Sep 17, 2016 at 11:34:22AM +0200, Peter Rosin wrote:
>>> From: Gustaf Lindström <gl@axentia.se>
>>>
>>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
>>>
>>> Signed-off-by: Gustaf Lindström <gl@axentia.se>
>>> Signed-off-by: Peter Rosin <peda@axentia.se>
>>> ---
>>>  .../bindings/display/panel/sharp,lq150x1lg11.txt   |  7 ++++++
>>>  drivers/gpu/drm/panel/panel-simple.c               | 27 ++++++++++++++++++++++
>>>  2 files changed, 34 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>>
>>> v1->v2: correct author
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>> new file mode 100644
>>> index 000000000000..014428c984c8
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>> @@ -0,0 +1,7 @@
>>> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq150x1lg11"
>>
>> Looking at the spec, what about 12V VDD, 3.3V VCC, XSTABY (backlight
>> ctrl), VBR (PWM), RL/UD, SELLVDS signals?
>
> I guess you're saying that simple-panel isn't the best match?

No, I'm only saying the h/w description should be complete.

> Is it
> ok to make the DT bindings more complete but still leave it to the
> simple-panel driver to support part of it?

Sure, all the properties can be optional though you should define the
default if not present. You're the first one, so you get to pick
defaults.

> Or should we just give
> up for the time being, and carry a local patch pending a custom
> driver?

Not at all.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] drm/panel: simple: add support for Sharp LQ150X1LG11  panels Rob Herring <robh@kernel.org> - 2016-09-23 19:40 +0200
  Re: [PATCH v2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Rob Herring <robh@kernel.org> - 2016-09-24 02:00 +0200

csiph-web