Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware

From	Ian Kent <raven@themaw.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware
Date	2016-09-24 02:20 +0200
Message-ID	<skIRc-2lT-3@gated-at.bofh.it> (permalink)
References	(8 earlier) <skezM-8hf-3@gated-at.bofh.it> <skn0l-53M-1@gated-at.bofh.it> <sknWp-5Dr-1@gated-at.bofh.it> <skqhz-7p6-3@gated-at.bofh.it> <skEky-7Ub-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-09-23 at 14:15 -0500, Eric W. Biederman wrote:
> Ian Kent <raven@themaw.net> writes:
> 
> 2> On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> > > Ian Kent <raven@themaw.net> writes:
> > > 
> > > > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> > > > > Ian Kent <raven@themaw.net> writes:
> > > > > 
> > > > > > Eric, Mateusz, I appreciate your spending time on this and
> > > > > > particularly
> > > > > > pointing
> > > > > > out my embarrassingly stupid is_local_mountpoint() usage mistake.
> > > > > > 
> > > > > > Please accept my apology for the inconvenience.
> > > > > > 
> > > > > > If all goes well (in testing) I'll have follow up patches to correct
> > > > > > this
> > > > > > fairly
> > > > > > soon.
> > > > > 
> > > > > Related question.  Do you happen to know how many mounts per mount
> > > > > namespace tend to be used?  It looks like it is going to be wise to
> > > > > put
> > > > > a configurable limit on that number.  And I would like the default to
> > > > > be
> > > > > something high enough most people don't care.  I believe autofs is
> > > > > likely where people tend to use the most mounts.
> > 
> > Yes, I agree, I did want to try and avoid changing the parameters to
> > ->d_mamange() but passing a struct path pointer might be better in the long
> > run
> > anyway.
> 
> Given that there is exactly one implementation of d_manage in the tree I
> don't imagine it will be disruptive to change that.

Yes, but it could be used by external modules.

And there's also have_submounts().

I can update that using the existing d_walk() infrastructure or take it (mostly)
into the autofs module and get rid of have_submounts().

I'll go with the former to start with and see what people think.

> 
> Eric

Thread

Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware ebiederm@xmission.com (Eric W. Biederman) - 2016-09-23 21:30 +0200
  Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware Ian Kent <raven@themaw.net> - 2016-09-24 02:20 +0200
    Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware ebiederm@xmission.com (Eric W. Biederman) - 2016-09-26 18:20 +0200
      Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware Ian Kent <raven@themaw.net> - 2016-09-27 04:00 +0200
        Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware ebiederm@xmission.com (Eric W. Biederman) - 2016-09-27 15:30 +0200
          Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware Ian Kent <raven@themaw.net> - 2016-09-28 02:20 +0200

csiph-web