Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk()

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk()
Date	2016-09-23 23:40 +0200
Message-ID	<skGml-EO-13@gated-at.bofh.it> (permalink)
References	<skDou-7lF-19@gated-at.bofh.it> <skEkx-7Ub-9@gated-at.bofh.it> <skG30-yx-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Sat, Sep 24, 2016 at 05:16:56AM +0800, zijun_hu wrote:
> On 2016/9/24 3:23, Tejun Heo wrote:
> > On Sat, Sep 24, 2016 at 02:20:24AM +0800, zijun_hu wrote:
> >> From: zijun_hu <zijun_hu@htc.com>
> >>
> >> correct max_distance from (base of the highest group + ai->unit_size)
> >> to (base of the highest group + the group size)
> >>
> >> Signed-off-by: zijun_hu <zijun_hu@htc.com>
> > 
> > Nacked-by: Tejun Heo <tj@kernel.org>
> > 
> > Thanks.
> >
> frankly, the current max_distance is error, doesn't represents the ranges spanned by
> areas owned by the groups

I think you're right but can you please update the patch description
so that it explains what the bug and the implications are and how the
patch fixes the bug.  Also, please make sure that all changes made by
the patch are explained in the description - e.g. why the type of
@max_distance is changed from size_t to ulong.

Thanks.

-- 
tejun

Thread

[PATCH 1/1] mm/percpu.c: correct max_distance calculation for  pcpu_embed_first_chunk() zijun_hu <zijun_hu@zoho.com> - 2016-09-23 20:30 +0200
  Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for  pcpu_embed_first_chunk() Tejun Heo <tj@kernel.org> - 2016-09-23 21:30 +0200
    Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for  pcpu_embed_first_chunk() zijun_hu <zijun_hu@zoho.com> - 2016-09-23 23:20 +0200
      Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for  pcpu_embed_first_chunk() Tejun Heo <tj@kernel.org> - 2016-09-23 23:40 +0200
  Re: [RESEND PATCH 1/1] mm/percpu.c: correct max_distance calculation  for pcpu_embed_first_chunk() zijun_hu <zijun_hu@zoho.com> - 2016-09-24 01:30 +0200
    Re: [RESEND PATCH 1/1] mm/percpu.c: correct max_distance calculation  for pcpu_embed_first_chunk() Tejun Heo <tj@kernel.org> - 2016-09-29 12:40 +0200
      Re: [RESEND PATCH 1/1] mm/percpu.c: correct max_distance calculation  for pcpu_embed_first_chunk() zijun_hu <zijun_hu@zoho.com> - 2016-09-29 13:30 +0200

csiph-web