Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490400

Re: [PATCH 1/1] mm/percpu.c: simplify grouping cpu logic in pcpu_build_alloc_info()

Show all headers | View raw

On Sat, Sep 24, 2016 at 02:15:09AM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
> 
> simplify grouping cpu logic in pcpu_build_alloc_info() to improve
> readability and performance, it discards the goto statement too
> 
> for every possible cpu, decide whether it can share group id of any
> lower index CPU, use the group id if so, otherwise a new group id
> is allocated to it
> 
> Signed-off-by: zijun_hu <zijun_hu@htc.com>

I'm not gonna change that code unless there are clear upsides.  It's a
complicated code path which is run once during boot.  It's not worth
optimizing, the author doesn't explain how the change has been tested
or verified and doesn't respond to people pointing out that these
drive-by patches aren't helpful.

I won't engage with his patches until he changes his approach and
think that it's advisable for others to do so too.

Nacked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] mm/percpu.c: simplify grouping cpu logic in  pcpu_build_alloc_info() zijun_hu <zijun_hu@zoho.com> - 2016-09-23 20:20 +0200
  Re: [PATCH 1/1] mm/percpu.c: simplify grouping cpu logic in  pcpu_build_alloc_info() Tejun Heo <tj@kernel.org> - 2016-09-23 21:30 +0200

csiph-web