Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1490324
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Thomas Gleixner <tglx@linutronix.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case. |
| Date | Fri, 23 Sep 2016 18:50:02 +0200 |
| Message-ID | <skBPI-6j6-37@gated-at.bofh.it> (permalink) |
| References | <skxj4-38t-27@gated-at.bofh.it> |
| X-Original-To | Arvind Yadav <arvind.yadav.cs@gmail.com> |
| User-Agent | Alpine 2.20 (DEB 67 2015-01-07) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 32 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | baohua@kernel.org, daniel.lezcano@linaro.org, LKML <linux-kernel@vger.kernel.org> |
| X-Original-Date | Fri, 23 Sep 2016 18:41:30 +0200 (CEST) |
| X-Original-Message-ID | <alpine.DEB.2.20.1609231831170.5640@nanos> |
| X-Original-References | <1474631874-5777-1-git-send-email-arvind.yadav.cs@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1490324 |
Show key headers only | View raw
On Fri, 23 Sep 2016, Arvind Yadav wrote:
So last time (V2) you had a almost perfect subject line:
clocksrouce/timer-imz-gpt: Prevent resource leaks in error path
The only issue was the clocksrcouce typo. Now you made it:
clocksource/timer-imx-gpt: Preventing resource leakage in error case.
Documentation/SubmittingPatches says:
Describe your changes in imperative mood ... as if you are giving orders
to the codebase to change its behaviour.
"Preventing" is not imperative and the above is not a proper sentence,
while the V2 one is.
> ret = _mxc_timer_init(imxtm);
> - if (ret)
> - return ret;
> + if (ret) {
> + goto error_iounmap;
> + }
Further Documentation/SubmittingPatches also tells you which tools to use
_before_ submission. If you'd used them then the above change would look
different. You surely can figure that out yourself.
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-23 14:00 +0200
Re: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case. Thomas Gleixner <tglx@linutronix.de> - 2016-09-23 18:50 +0200
Re: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case. arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-24 09:50 +0200
csiph-web