[PATCH net-next 05/15] rxrpc: Use before_eq() and friends to compare serial numbers

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH net-next 05/15] rxrpc: Use before_eq() and friends to compare serial numbers
Date	2016-09-23 17:20 +0200
Message-ID	<skAqB-5wp-15@gated-at.bofh.it> (permalink)
References	<skAqB-5wp-5@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

before_eq() and friends should be used to compare serial numbers (when not
checking for (non)equality) rather than casting to int, subtracting and
checking the result.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/input.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index cbb5d53f09d7..06027b6d9c19 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -578,7 +578,7 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb,
 	}
 
 	/* Discard any out-of-order or duplicate ACKs. */
-	if ((int)sp->hdr.serial - (int)call->acks_latest <= 0) {
+	if (before_eq(sp->hdr.serial, call->acks_latest)) {
 		_debug("discard ACK %d <= %d",
 		       sp->hdr.serial, call->acks_latest);
 		return;

Thread

[PATCH net-next 00/15] rxrpc: Bug fixes and tracepoints David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 13/15] rxrpc: Add a tracepoint to log injected Rx  packet loss David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 11/15] rxrpc: Add a tracepoint for the call timer David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 05/15] rxrpc: Use before_eq() and friends to  compare serial numbers David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 10/15] rxrpc: Don't call the tx_ack tracepoint if  don't generate an ACK David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 08/15] rxrpc: Fix call timer David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
    Re: [PATCH net-next 08/15] rxrpc: Fix call timer Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-23 20:10 +0200
      Re: [PATCH net-next 08/15] rxrpc: Fix call timer David Howells <dhowells@redhat.com> - 2016-09-23 20:30 +0200
  [PATCH net-next 09/15] rxrpc: Pass the last Tx packet marker in the  annotation buffer David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 04/15] rxrpc: Should be using ktime_add_ms() not  ktime_add_ns() David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 03/15] rxrpc: Make sure sendmsg() is woken on call  completion David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 14/15] rxrpc: Add tracepoint for ACK proposal David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 15/15] rxrpc: Add a tracepoint to log which packets  will be retransmitted David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 01/15] rxrpc: Preset timestamp on Tx sk_buffs David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of  scheduled resend by ACK parser David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
    Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of  scheduled resend by ACK parser Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-23 20:10 +0200
      Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser David Howells <dhowells@redhat.com> - 2016-09-23 20:30 +0200
  [PATCH net-next 06/15] rxrpc: Need to start the resend timer on  initial transmission David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200
  Re: [PATCH net-next 00/15] rxrpc: Bug fixes and tracepoints David Miller <davem@davemloft.net> - 2016-09-24 14:30 +0200

csiph-web