RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

From	Paul Durrant <Paul.Durrant@citrix.com>
Newsgroups	linux.kernel
Subject	RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring
Date	2016-09-22 12:40 +0200
Message-ID	<sk9A6-58y-39@gated-at.bofh.it> (permalink)
References	<sk8b0-4nG-13@gated-at.bofh.it> <sk8kF-4r1-9@gated-at.bofh.it> <sk9gJ-51T-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Juergen Gross [mailto:jgross@suse.com]
> Sent: 22 September 2016 11:17
> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org;
> netdev@vger.kernel.orga <netdev@vger.kernel.org>; linux-
> kernel@vger.kernel.org
> Cc: Wei Liu <wei.liu2@citrix.com>
> Subject: Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq
> for control ring
> 
> On 22/09/16 11:09, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of
> >> Juergen Gross
> >> Sent: 22 September 2016 10:03
> >> To: xen-devel@lists.xenproject.org; netdev@vger.kernel.orga; linux-
> >> kernel@vger.kernel.org
> >> Cc: Juergen Gross <jgross@suse.com>; Wei Liu <wei.liu2@citrix.com>
> >> Subject: [Xen-devel] [PATCH resend] xen-netback: switch to threaded
> >> irq for control ring
> >>
> >> Instead of open coding it use the threaded irq mechanism in xen-netback.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >
> > How have you tested this change?
> 
> Only compile-tested and loaded the module. As this feature isn't being used
> in linux netfront AFAIK it is not easily testable. OTOH the code modification is
> rather limited and I've used the threaded irq in the Xen scsiback driver
> myself, so I'm rather confident it will work.
> 

OK. How about doing the rx interrupt/task too so that it can be easily tested with a linux netfront?

  Paul

> 
> Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH resend] xen-netback: switch to threaded irq for control ring Juergen Gross <jgross@suse.com> - 2016-09-22 11:10 +0200
  RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq  for    control ring Paul Durrant <Paul.Durrant@citrix.com> - 2016-09-22 11:20 +0200
    Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq  for control ring Juergen Gross <jgross@suse.com> - 2016-09-22 12:20 +0200
      Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq  for control ring Juergen Gross <jgross@suse.com> - 2016-09-22 12:40 +0200
        RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq  for control ring Paul Durrant <Paul.Durrant@citrix.com> - 2016-09-22 12:50 +0200
      RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq  for control ring Paul Durrant <Paul.Durrant@citrix.com> - 2016-09-22 12:40 +0200

csiph-web