Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488684

Re: [PATCH] docs: Remove space-before-label guidance from CodingStyle

Show all headers | View raw

Hi Jonathan,

On Wed, 21 Sep 2016 15:54:01 -0600, Jonathan Corbet wrote:
> Recent discussion has made it clear that there is no community consensus
> on this particular rule.  Remove it now, lest it inspire yet another set
> of unwanted "cleanup" patches.
> 
> This partially reverts 865a1caa4b6b (CodingStyle: Clarify and complete
> chapter 7).
> (...)
> @@ -481,7 +478,7 @@ The rationale for using gotos is:
>  			goto out_buffer;
>  		}
>  		...
> -	 out_free_buffer:
> +	out_free_buffer:
>  		kfree(buffer);
>  		return result;
>  	}
> @@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err
> bugs`` which look like this: 
>  .. code-block:: c
>  
> -	 err:
> +	err:
>  		kfree(foo->bar);
>  		kfree(foo);
>  		return ret;

There are 2 more occurrences after this point, which you probably want
to change too.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] docs: Remove space-before-label guidance from CodingStyle Jonathan Corbet <corbet@lwn.net> - 2016-09-22 00:00 +0200
  Re: [PATCH] docs: Remove space-before-label guidance from  CodingStyle Joe Perches <joe@perches.com> - 2016-09-22 00:50 +0200
  Re: [PATCH] docs: Remove space-before-label guidance from  CodingStyle Jean Delvare <jdelvare@suse.de> - 2016-09-22 11:30 +0200

csiph-web