Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488677

Re: [PATCHv2] arm64: Correctly bounds check virt_addr_valid

Show all headers | View raw

On Wed, Sep 21, 2016 at 03:25:04PM -0700, Laura Abbott wrote:
> 
> virt_addr_valid is supposed to return true if and only if virt_to_page
> returns a valid page structure. The current macro does math on whatever
> address is given and passes that to pfn_valid to verify. vmalloc and
> module addresses can happen to generate a pfn that 'happens' to be
> valid. Fix this by only performing the pfn_valid check on addresses that
> have the potential to be valid.
> 
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v2: Properly parenthesize macro arguments. Re-factor to common macro.
> 
> Also in case it wasn't clear, there's no need to try and squeeze this
> into 4.8. Hardened usercopy should have all the checks, this is just for
> full correctness.

Thanks, I'll push this onto for-next/core later today.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] arm64: Correctly bounds check virt_addr_valid Laura Abbott <labbott@redhat.com> - 2016-09-22 00:30 +0200
  Re: [PATCHv2] arm64: Correctly bounds check virt_addr_valid Kees Cook <keescook@chromium.org> - 2016-09-22 01:50 +0200
  Re: [PATCHv2] arm64: Correctly bounds check virt_addr_valid Will Deacon <will.deacon@arm.com> - 2016-09-22 11:20 +0200

csiph-web