Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488686

Re: [PATCH] KVM: nVMX: Fix the NMI IDT-vectoring info handling

Show all headers | View raw

On 22/09/2016 05:34, Wanpeng Li wrote:
> -	if (vmx->rmode.vm86_active) {
> -		if (kvm_inject_realmode_interrupt(vcpu, NMI_VECTOR, 0) != EMULATE_DONE)
> -			kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu);
> -		return;
> +		++vcpu->stat.nmi_injections;
> +		vmx->nmi_known_unmasked = false;
> +		if (vmx->rmode.vm86_active) {
> +			if (kvm_inject_realmode_interrupt(vcpu, NMI_VECTOR, 0) != EMULATE_DONE)
> +				kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu);
> +			return;
> +		}
>  	}
>  	vmcs_write32(VM_ENTRY_INTR_INFO_FIELD,
>  			INTR_TYPE_NMI_INTR | INTR_INFO_VALID_MASK | NMI_VECTOR);

Hi,

the patch is mostly okay but the "if (vmx->rmode.vm86_active)" part
should be done also if the VCPU is in guest mode.  See
vmx_queue_exception for a similar example.

I would like to know which processors lack virtual NMI support.  I'd
rather rip that code out...

Thanks,

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: nVMX: Fix the NMI IDT-vectoring info handling Wanpeng Li <kernellwp@gmail.com> - 2016-09-22 05:40 +0200
  Re: [PATCH] KVM: nVMX: Fix the NMI IDT-vectoring info handling Paolo Bonzini <pbonzini@redhat.com> - 2016-09-22 11:40 +0200
    Re: [PATCH] KVM: nVMX: Fix the NMI IDT-vectoring info handling Wanpeng Li <kernellwp@gmail.com> - 2016-09-22 11:50 +0200
      Re: [PATCH] KVM: nVMX: Fix the NMI IDT-vectoring info handling Jan Kiszka <jan.kiszka@siemens.com> - 2016-09-22 12:10 +0200

csiph-web