Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488537

Re: [PATCH] HID: alps: fix stick device not working after resume

From Kai Heng Feng <kai.heng.feng@canonical.com>
Newsgroups linux.kernel
Subject Re: [PATCH] HID: alps: fix stick device not working after resume
Date 2016-09-22 07:20 +0200
Message-ID <sk4Ap-2ay-5@gated-at.bofh.it> (permalink)
References <sj1uV-2ya-15@gated-at.bofh.it> <sj61A-5sG-17@gated-at.bofh.it> <sj998-7ii-19@gated-at.bofh.it> <sjOvE-p7-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 21, 2016 at 8:00 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Mon, 19 Sep 2016, Kai Heng Feng wrote:
>
>> >> The stick device does not work after resume, add U1_SP_ABS_MODE flag can
>> >> make the device work after resume.
>> >
>> > Do you happen to have any more details on why it doesn't work without
>> > U1_SP_ABS_MODE? Or was this a pure guesswork?
>>
>> It' pure guesswork, based on how the existing code uses U1_TP_ABS_MODE flag
>> on both initialization and resume.
>>
>> I also tested the the patch on an ALPS touchpad without stick device,
>> did not notice
>> any side effect on suspend/resume, so I made the U1_SP_ABS_MODE flag mandatory.
>
> I'll fold this information into the patch changelog before comitting; if
> you disagree, please let me know.

That will be great.
Appreciate!

>
> --
> Jiri Kosina
> SUSE Labs
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] HID: alps: fix stick device not working after resume Kai-Heng Feng <kai.heng.feng@canonical.com> - 2016-09-19 09:50 +0200
  Re: [PATCH] HID: alps: fix stick device not working after resume Jiri Kosina <jikos@kernel.org> - 2016-09-19 14:40 +0200
    Re: [PATCH] HID: alps: fix stick device not working after resume Kai Heng Feng <kai.heng.feng@canonical.com> - 2016-09-19 18:00 +0200
      Re: [PATCH] HID: alps: fix stick device not working after resume Jiri Kosina <jikos@kernel.org> - 2016-09-21 14:10 +0200
        Re: [PATCH] HID: alps: fix stick device not working after resume Kai Heng Feng <kai.heng.feng@canonical.com> - 2016-09-22 07:20 +0200
  Re: [PATCH] HID: alps: fix stick device not working after resume Jiri Kosina <jikos@kernel.org> - 2016-09-22 11:10 +0200

csiph-web