Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487454

Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices

Show all headers | View raw

Hi Boris

Thanks for your review.

On Tue, Sep 20, 2016 at 1:21 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
>>       int sr, fsr;
>> -     sr = spi_nor_sr_ready(nor);
>> +
>> +     sr = nor->flags & SNOR_F_READY_XSR_RDY ? s3an_sr_ready(nor) :
>> +                                              spi_nor_sr_ready(nor);
>
> Nit: I find
>
>         if (nor->flags & SNOR_F_READY_XSR_RDY)
>                 sr = s3an_sr_ready(nor);
>         else
>                 sr = spi_nor_sr_ready(nor);

Fixed in v6


>> +static loff_t spi_nor_s3an_addr_convert(struct spi_nor *nor, unsigned int addr)
>> +{
>> +     unsigned int offset;
>> +
>> +     offset = (nor->page_size == 264) ? (addr % 264) : (addr % 528);
>
> Why not just
>
>         offset = addr % nor->page_size;
>

Because kbuild test robot does not like it ;)

        make.cross ARCH=blackfin

All errors (new ones prefixed by >>):

   drivers/built-in.o: In function `spi_nor_write':
>> drivers/mtd/spi-nor/spi-nor.c:1050: undefined reference to `__moddi3'

vim +1050 drivers/mtd/spi-nor/spi-nor.c



Thanks!
-- 
Ricardo Ribalda

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-09-16 21:40 +0200
  Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-09-20 12:00 +0200
  Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-09-20 13:30 +0200
    Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-09-20 17:50 +0200
      Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-09-20 18:20 +0200
  Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-09-20 18:30 +0200
    Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-09-20 20:10 +0200

csiph-web