Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487462

[PATCH] x86/dumpstack: fix show_stack() task pointer regression

Show all headers | View raw

On Tue, Sep 20, 2016 at 08:01:02AM -0700, tip-bot for Josh Poimboeuf wrote:
> Commit-ID:  e18bcccd1a4ecb41e99678e002ef833586185bf1
> Gitweb:     http://git.kernel.org/tip/e18bcccd1a4ecb41e99678e002ef833586185bf1
> Author:     Josh Poimboeuf <jpoimboe@redhat.com>
> AuthorDate: Fri, 16 Sep 2016 14:18:16 -0500
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 20 Sep 2016 08:29:34 +0200
> 
> x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder

Ingo,

My apologies, I introduced a small regression with this patch -- another
rebase gone bad.  Here's the fix:

---

From: Josh Poimboeuf <jpoimboe@redhat.com>
Subject: [PATCH] x86/dumpstack: fix show_stack() task pointer regression

With the following commit:

  e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder")

The task pointer argument to show_stack_log_lvl() in show_stack() was
inadvertently changed to 'current'.

Fixes: e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 arch/x86/kernel/dumpstack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 999de3b..9b7cf5c 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -164,7 +164,7 @@ void show_stack(struct task_struct *task, unsigned long *sp)
 	if (!sp && task == current)
 		sp = get_stack_pointer(current, NULL);
 
-	show_stack_log_lvl(current, NULL, sp, "");
+	show_stack_log_lvl(task, NULL, sp, "");
 }
 
 void show_stack_regs(struct pt_regs *regs)
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 5/6] x86/dumpstack: convert show_trace_log_lvl() to use the new unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-16 21:20 +0200
  [tip:x86/asm] x86/dumpstack: Convert show_trace_log_lvl() to use  the new unwinder tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-09-20 17:10 +0200
    [PATCH] x86/dumpstack: fix show_stack() task pointer regression Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-20 18:00 +0200
      [tip:x86/asm] x86/dumpstack: Fix show_stack() task pointer  regression tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-09-21 00:00 +0200

csiph-web