Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487468

[PATCH 1/2] perf/x86/intel/bts: Make it an exclusive PMU

From Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] perf/x86/intel/bts: Make it an exclusive PMU
Date 2016-09-20 18:00 +0200
Message-ID <sjvCG-4Ws-33@gated-at.bofh.it> (permalink)
References <sjvCG-4Ws-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Just like intel_pt, intel_bts can only handle one event at a time,
which is the reason we introduced PERF_PMU_CAP_EXCLUSIVE in the first
place. However, at the moment one can have as many intel_bts events
within the same context at the same time as one pleases. Only one of
them, however, will get scheduled and receive the actual trace data.

Fix this by making intel_bts an "exclusive" PMU.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 arch/x86/events/intel/bts.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/bts.c b/arch/x86/events/intel/bts.c
index bdcd651099..6112c3d538 100644
--- a/arch/x86/events/intel/bts.c
+++ b/arch/x86/events/intel/bts.c
@@ -584,7 +584,8 @@ static __init int bts_init(void)
 	if (!boot_cpu_has(X86_FEATURE_DTES64) || !x86_pmu.bts)
 		return -ENODEV;
 
-	bts_pmu.capabilities	= PERF_PMU_CAP_AUX_NO_SG | PERF_PMU_CAP_ITRACE;
+	bts_pmu.capabilities	= PERF_PMU_CAP_AUX_NO_SG | PERF_PMU_CAP_ITRACE |
+				  PERF_PMU_CAP_EXCLUSIVE;
 	bts_pmu.task_ctx_nr	= perf_sw_context;
 	bts_pmu.event_init	= bts_event_init;
 	bts_pmu.add		= bts_event_add;
-- 
2.9.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] perf, bts: Make BTS exclusive again Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-09-20 18:00 +0200
  [PATCH 2/2] perf: Limit matching exclusive events to one PMU Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-09-20 18:00 +0200
    [tip:perf/urgent] perf/core: Limit matching exclusive events to one  PMU tip-bot for Alexander Shishkin <tipbot@zytor.com> - 2016-09-22 16:10 +0200
  [PATCH 1/2] perf/x86/intel/bts: Make it an exclusive PMU Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-09-20 18:00 +0200
    [tip:perf/urgent] perf/x86/intel/bts: Make it an exclusive PMU tip-bot for Alexander Shishkin <tipbot@zytor.com> - 2016-09-22 16:10 +0200

csiph-web