Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487418

[tip:smp/hotplug] cpufreq: Fix up conversion to hotplug state machine

Show all headers | View raw

Commit-ID:  5372e054a1928fe704cf0a5e2e139645a777b50a
Gitweb:     http://git.kernel.org/tip/5372e054a1928fe704cf0a5e2e139645a777b50a
Author:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
AuthorDate: Tue, 20 Sep 2016 16:56:28 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 20 Sep 2016 16:59:21 +0200

cpufreq: Fix up conversion to hotplug state machine

The function cpufreq_register_driver() returns zero on success and since
commit 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
erroneously a positive number. Due to the "if (x) assume_error" construct
all callers assumed an error and as a consequence the cpu freq kworker
crashes with a NULL pointer dereference.

Reset the return value back to zero in the success case.

Fixes: 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
Reported-by: Borislav Petkov <bp@alien8.de>
Reported-and-tested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: peterz@infradead.org
Cc: rjw@rjwysocki.net
Link: http://lkml.kernel.org/r/20160920145628.lp2bmq72ip3oiash@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 drivers/cpufreq/cpufreq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index e0bc632..8b44de4 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2503,6 +2503,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
 	if (ret < 0)
 		goto err_if_unreg;
 	hp_online = ret;
+	ret = 0;
 
 	pr_debug("driver %s up and running\n", driver_data->name);
 	goto out;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[tip:smp/hotplug] cpufreq: Convert to hotplug state machine tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-09-19 22:00 +0200
  [PATCH] cpufreq: fix up conversion to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-09-20 17:00 +0200
    [tip:smp/hotplug] cpufreq: Fix up conversion to hotplug state  machine tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-09-20 17:10 +0200
      Re: [tip:smp/hotplug] cpufreq: Fix up conversion to hotplug state  machine Borislav Petkov <bp@alien8.de> - 2016-09-20 18:10 +0200
    Re: [PATCH] cpufreq: fix up conversion to hotplug state machine "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-09-20 18:20 +0200

csiph-web