Re: GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()
Date	2016-09-20 13:20 +0200
Message-ID	<sjrfH-2eQ-9@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <sjp4d-EF-5@gated-at.bofh.it> <sjpdT-WX-13@gated-at.bofh.it> <sjq9X-1yF-9@gated-at.bofh.it> <sjqWl-1To-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>> A single error message should be sufficient to inform about
>>> the detection of an unknown GCT revision at the end.
>>> Thus return after the logging call in this case directly.
>>
>> Did you test this?
>>
> 
> Don't be a dummy...  This is easy to review an it fixes a bug.

Thanks for this kind of constructive feedback.


> I'm fine with you NAKing all these patches based on who they are from.

Would you like to clarify such an information a bit more?


> I mostly just delete these without responding because the guy has
> history of introducing bugs and never listens to feedback.

I admit that I'll stumble on programming mistakes again occasionally
as another ordinary free software developer who is struggling various open issues.

I am listening to various feedback. My responses might not be pleasing enough
for you. Are you looking for any special information to improve
a corresponding discussion?

Regards,
Markus

Thread

[PATCH 0/6] GPU-DRM-GMA500: Fine-tuning for two function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 11:00 +0200
  [PATCH 2/6] GPU-DRM-GMA500: Rename a jump label in  mid_get_vbt_data_r10() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 11:00 +0200
    Re: [PATCH 2/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data_r10() Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-20 12:10 +0200
  [PATCH 3/6] GPU-DRM-GMA500: Move a variable assignment in  mid_get_vbt_data_r10() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 11:00 +0200
  [PATCH 4/6] GPU-DRM-GMA500: Fix indentation for a function call  parameter in mid_get_vbt_data_r10() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 11:10 +0200
  [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision  mismatch in mid_get_vbt_data() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 11:10 +0200
    Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data() Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-20 12:10 +0200
      Re: GPU-DRM-GMA500: One error message less for a GCT revision  mismatch in mid_get_vbt_data() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 12:40 +0200
      Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT  revision mismatch in mid_get_vbt_data() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-20 13:00 +0200
        Re: GPU-DRM-GMA500: One error message less for a GCT revision  mismatch in mid_get_vbt_data() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-20 13:20 +0200
          Re: GPU-DRM-GMA500: One error message less for a GCT revision  mismatch in mid_get_vbt_data() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 13:40 +0200
        Re: GPU-DRM-GMA500: One error message less for a GCT revision  mismatch in mid_get_vbt_data() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 13:20 +0200
        Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data() Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-20 14:10 +0200
          Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT  revision mismatch in mid_get_vbt_data() Patrik Jakobsson <patrik.r.jakobsson@gmail.com> - 2016-09-20 22:30 +0200
  [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-20 11:10 +0200
    Re: [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data() Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-20 12:10 +0200
      Re: [PATCH 6/6] GPU-DRM-GMA500: Rename a jump label in  mid_get_vbt_data() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-20 14:50 +0200

csiph-web