Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings
Date	Tue, 20 Sep 2016 13:00:01 +0200
Message-ID	<sjqWl-1To-5@gated-at.bofh.it> (permalink)
References	<sjgWZ-4au-3@gated-at.bofh.it> <sjgWZ-4au-1@gated-at.bofh.it>
X-Original-To	kbuild test robot <fengguang.wu@intel.com>
User-Agent	Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version	1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Andrej Krutak <dev@andree.sk>, kbuild-all@01.org, alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 20 Sep 2016 12:54:20 +0200
X-Original-Message-ID	<s5h4m5au9ib.wl-tiwai@suse.de>
X-Original-References	<201609200807.amTCnbAm%fengguang.wu@intel.com> <20160920001013.GA15786@lkp-hsx03.lkp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1487233

Show key headers only | View raw

On Tue, 20 Sep 2016 02:10:13 +0200,
kbuild test robot wrote:
> 
> sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> CC: Andrej Krutak <dev@andree.sk>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.


Takashi


> ---
> 
>  driver.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca
>  	/* Free buffer memory first. We cannot depend on the existence of private
>  	 * data from the (podhd) module, it may be gone already during this call
>  	 */
> -	if (line6->buffer_message)
> -		kfree(line6->buffer_message);
> +	kfree(line6->buffer_message);
>  
>  	kfree(line6->buffer_listen);
>  
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: line6: fix ifnullfree.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2016-09-20 02:20 +0200
  Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings Takashi Iwai <tiwai@suse.de> - 2016-09-20 13:00 +0200

csiph-web