Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487180

Re: [PATCH] drm/omap: fix return value check in dsi_bind()

Show all headers | View raw

On 09/17/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index e1be5e7..a567ebd 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -5342,7 +5342,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->phy_base) {
>  		DSSERR("can't ioremap DSI PHY\n");
>  		return -ENOMEM;
>  	}
> @@ -5362,7 +5362,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->pll_base) {
>  		DSSERR("can't ioremap DSI PLL\n");
>  		return -ENOMEM;
>  	}
> 
> 
> 


-- 
Péter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/omap: fix return value check in dsi_bind() Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-17 18:00 +0200
  Re: [PATCH] drm/omap: fix return value check in dsi_bind() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-20 11:30 +0200

csiph-web