Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to alloc_msi_entry

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to alloc_msi_entry
Date	2016-09-20 11:10 +0200
Message-ID	<sjpdT-WX-7@gated-at.bofh.it> (permalink)
References	<shjcB-1Ui-7@gated-at.bofh.it> <shjcB-1Ui-9@gated-at.bofh.it> <sj1bz-2rl-17@gated-at.bofh.it> <sj7gZ-69i-5@gated-at.bofh.it> <sjnlM-8eo-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 20 Sep 2016, Alexander Gordeev wrote:
> On Mon, Sep 19, 2016 at 03:50:07PM +0200, Christoph Hellwig wrote:
> > On Mon, Sep 19, 2016 at 09:30:58AM +0200, Alexander Gordeev wrote:
> > > >  	INIT_LIST_HEAD(&desc->list);
> > > >  	desc->dev = dev;
> > > > +	desc->nvec_used = nvec;
> 
> (*)
> 
> > > > +	if (affinity) {
> > > > +		desc->affinity = kmemdup(affinity,
> > > > +			nvec * sizeof(*desc->affinity), GFP_KERNEL);
> > > > +		if (!desc->affinity) {
> > > > +			kfree(desc);
> > > > +			return NULL;
> > > > +		}
> > > > +	}
> > > 
> > > nit - should not "desc" initialization follow "desc->affinity" allocation?
> > 
> > I can't parse that sentence.  Do you mean the desc->nvec_used setup?
> 
> Yes, the inits above (*) would be useless if desc->affinity allocation failed.

And that matters how?

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/13] genirq/msi: Add cpumask allocation to alloc_msi_entry Christoph Hellwig <hch@lst.de> - 2016-09-14 16:20 +0200
  [tip:irq/core] genirq/msi: Add cpumask allocation to  alloc_msi_entry tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-09-15 21:10 +0200
  Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to  alloc_msi_entry Alexander Gordeev <agordeev@redhat.com> - 2016-09-19 09:30 +0200
    Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to         alloc_msi_entry Christoph Hellwig <hch@lst.de> - 2016-09-19 16:00 +0200
      Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to  alloc_msi_entry Alexander Gordeev <agordeev@redhat.com> - 2016-09-20 09:10 +0200
        Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to  alloc_msi_entry Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 11:10 +0200

csiph-web