Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487168

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md
Date 2016-09-20 11:00 +0200
Message-ID <sjp4e-EF-17@gated-at.bofh.it> (permalink)
References <sjayf-8kP-63@gated-at.bofh.it> <sjn2p-7SH-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > was done when porting to the upstream client.
> 
> How did our build testing not catch this?  What needs these exports?  Is
> it any in-kernel code?
> 
> confused,

It did catch it...  James, every patch has to be buildable (bisectable)
so the original patch is never going to be merged.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md James Simmons <jsimmons@infradead.org> - 2016-09-19 19:30 +0200
  Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-20 08:50 +0200
    Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-20 11:00 +0200
      Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-20 13:20 +0200
        Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-20 13:40 +0200
        Re: [lustre-devel] [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md James Simmons <jsimmons@infradead.org> - 2016-09-20 17:40 +0200
      Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-20 13:20 +0200
      Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md James Simmons <jsimmons@infradead.org> - 2016-09-20 17:20 +0200
  Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-20 13:20 +0200
    Re: [PATCH] staging: lustre: ptlrpc: re-export  lustre_swab_[lmv|lov]_mds_md James Simmons <jsimmons@infradead.org> - 2016-09-20 18:00 +0200

csiph-web