Re: [PATCH] net: hns: mark symbols static where possible

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: hns: mark symbols static where possible
Date	2016-09-20 04:00 +0200
Message-ID	<sjivL-4Vq-5@gated-at.bofh.it> (permalink)
References	<siGgN-6gf-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Baoyou Xie <baoyou.xie@linaro.org>
Date: Sun, 18 Sep 2016 17:07:25 +0800

> We get a few warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous prototype for 'hns_ae_get_handle' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Does not apply cleanly to net-next, please respin.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: hns: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 11:10 +0200
  Re: [PATCH] net: hns: mark symbols static where possible David Miller <davem@davemloft.net> - 2016-09-20 04:00 +0200

csiph-web