Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486978

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

Show all headers | View raw

On Mon, Sep 19, 2016 at 08:29:40PM -0400, Vivien Didelot wrote:
> Hi Andrew,
> 
> Andrew Lunn <andrew@lunn.ch> writes:
> 
> > Hi Vivien
> >
> >> +	do {
> >> +		err = _mv88e6xxx_atu_getnext(chip, fid, &next);
> >> +		if (err)
> >> +			return err;
> >> +
> >> +		if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED)
> >> +			break;
> >> +
> >> +		if (ether_addr_equal(next.mac, addr)) {
> >> +			*entry = next;
> >> +			return 0;
> >> +		}
> >> +	} while (!is_broadcast_ether_addr(next.mac));
> >
> > This is correct, but i wonder how well it scales? When we have a lot
> > of entries in the ATU, this is going to take time. At some point in
> > the future, we might want to keep a shadow copy of static entries of
> > the ATU in RAM. We then don't need to search for them.
> 
> There won't be any issue about time here, because we are searching a
> precise FID.

Ah, i didn't realise you can do that. However, it makes sense, the
hardware needs to do it all the time when it receives a frame.

	 Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-20 02:00 +0200
  Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in  ATU Andrew Lunn <andrew@lunn.ch> - 2016-09-20 02:20 +0200
    Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-20 02:30 +0200
      Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in  ATU Andrew Lunn <andrew@lunn.ch> - 2016-09-20 02:40 +0200
  Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in  ATU Andrew Lunn <andrew@lunn.ch> - 2016-09-20 02:50 +0200
    Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-20 03:10 +0200
      Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in  ATU Andrew Lunn <andrew@lunn.ch> - 2016-09-21 01:50 +0200
  Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in  ATU David Miller <davem@davemloft.net> - 2016-09-21 06:10 +0200

csiph-web