Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486989

Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy

Show all headers | View raw

On Mon, Sep 19, 2016 at 5:05 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Sep 13, 2016 at 04:45:51PM +0900, Namhyung Kim wrote:
>> When --hierarchy option is used, each entry has its own hpp_list to show
>> the result.  But it missed to update width of each column.
>>
>> Fixes: 1b2dbbf41a0f ("perf hists: Use own hpp_list for hierarchy mode")
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>> ---
>>  tools/perf/ui/browsers/hists.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
>> index 35e44b1879e3..49db16334814 100644
>> --- a/tools/perf/ui/browsers/hists.c
>> +++ b/tools/perf/ui/browsers/hists.c
>> @@ -2067,6 +2067,7 @@ void hist_browser__init(struct hist_browser *browser,
>>                       struct hists *hists)
>>  {
>>       struct perf_hpp_fmt *fmt;
>> +     struct perf_hpp_list_node *node;
>>
>>       browser->hists                  = hists;
>>       browser->b.refresh              = hist_browser__refresh;
>> @@ -2079,6 +2080,11 @@ void hist_browser__init(struct hist_browser *browser,
>>               perf_hpp__reset_width(fmt, hists);
>>               ++browser->b.columns;
>>       }
>> +     /* hierarchy entries have their own hpp list */
>> +     list_for_each_entry(node, &hists->hpp_formats, list) {
>> +             perf_hpp_list__for_each_format(&node->hpp, fmt)
>> +                     perf_hpp__reset_width(fmt, hists);
>> +     }
>
> we could add new function hists__reset_width and use it from
> both std and tui code

Will do as a follow-up patch!

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-13 09:50 +0200
  Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Jiri Olsa <jolsa@redhat.com> - 2016-09-19 10:10 +0200
    Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-20 03:20 +0200
      Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-20 16:10 +0200

csiph-web