Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf

From	Al Stone <ahs3@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf
Date	2016-09-19 21:00 +0200
Message-ID	<sjbXj-EM-3@gated-at.bofh.it> (permalink)
References	<shrtw-7hp-27@gated-at.bofh.it> <sht2h-8g5-1@gated-at.bofh.it> <shvdL-1or-1@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

On 09/14/2016 09:06 PM, Hoan Tran wrote:
> Hi Rafael,
> 
> On Wed, Sep 14, 2016 at 5:50 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> On Wednesday, September 14, 2016 04:08:28 PM Hoan Tran wrote:
>>> This patch fixes overflow issue when calculating the desired_perf.
>>>
>>> Signed-off-by: Hoan Tran <hotran@apm.com>
>>> ---
>>>  drivers/cpufreq/cppc_cpufreq.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
>>> index 894e465..3e0961e 100644
>>> --- a/drivers/cpufreq/cppc_cpufreq.c
>>> +++ b/drivers/cpufreq/cppc_cpufreq.c
>>> @@ -84,7 +84,8 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
>>>
>>>       cpu = all_cpu_data[policy->cpu];
>>>
>>> -     cpu->perf_ctrls.desired_perf = target_freq * policy->max / cppc_dmi_max_khz;
>>> +     cpu->perf_ctrls.desired_perf =
>>> +             (u64)target_freq * policy->max / cppc_dmi_max_khz;
>>>       freqs.old = policy->cur;
>>>       freqs.new = target_freq;
>>
>> That's on top of the CPPC material in linux-next I gather?
> 
> Yes, it's on TOP of linux-next.
> 
>>
>> Which commit does it fix?
> 
> This is a fix for ad38677df44b67e0f5b6c4d31e9c2734abde8ed9 (cpufreq:
> CPPC: Force reporting values in KHz to fix user space interface)
> http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/cpufreq/cppc_cpufreq.c?id=ad38677df44b67e0f5b6c4d31e9c2734abde8ed9
> 
> Thanks
> Hoan
> 
>>
>> Thanks,
>> Rafael
>>

Nice catch, Hoan.  Thanks!

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf Hoan Tran <hotran@apm.com> - 2016-09-15 01:10 +0200
  Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-09-15 02:50 +0200
    Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf Hoan Tran <hotran@apm.com> - 2016-09-15 05:10 +0200
      Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating  desired_perf Al Stone <ahs3@redhat.com> - 2016-09-19 21:00 +0200

csiph-web