Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

From	arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap
Date	2016-09-19 19:50 +0200
Message-ID	<sjaRA-8rr-17@gated-at.bofh.it> (permalink)
References	<ds889-8u2-7@gated-at.bofh.it> <shfVo-8d0-7@gated-at.bofh.it> <shn6x-4hB-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Wednesday 14 September 2016 11:54 PM, Stephen Boyd wrote:
> On 09/14, arvind.yadav.cs@gmail.com wrote:
>> @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np)
>>   	return;
>>   
>>   err:
>> +	if (reg)
> This is always true? Why check?
> I have removed this check. Please review updated patch.
>> +		iounmap(reg);
>>   	if (clk_data)
>>   		kfree(clk_data->clks);
>>   	kfree(clk_data);
>> -- 
>> 1.7.9.5
>>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap arvind.yadav.cs@gmail.com - 2016-09-14 12:50 +0200
  Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap Stephen Boyd <sboyd@codeaurora.org> - 2016-09-14 20:30 +0200
    Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-19 19:50 +0200

csiph-web