Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

From	zijun_hu <zijun_hu@zoho.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()
Date	2016-09-22 02:00 +0200
Message-ID	<sjZAJ-78n-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <sjX5T-5Jq-1@gated-at.bofh.it> <sjYlk-6tw-21@gated-at.bofh.it> <sjYuZ-6wT-5@gated-at.bofh.it> <sjYY1-6VQ-5@gated-at.bofh.it> <sjYY1-6VQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/9/22 7:15, David Rientjes wrote:
> On Thu, 22 Sep 2016, zijun_hu wrote:
> 
>>> We don't support inserting when va->va_start == tmp_va->va_end, plain and 
>>> simple.  There's no reason to do so.  NACK to the patch.
>>>
>> i am sorry i disagree with you because
>> 1) in almost all context of vmalloc, original logic treat the special case as normal
>>    for example, __find_vmap_area() or alloc_vmap_area()
> 
> The ranges are [start, end) like everywhere else.  __find_vmap_area() is 
> implemented as such for the passed address.  The address is aligned in 
> alloc_vmap_area(), there's no surprise here.  The logic is correct in 
> __insert_vmap_area().
> 
1) is the desire behavior of __insert_vmap_area() conform with that mentioned
   in my comments?
2) which way of code implementation can present the desire purpose more clear
   and more understandable?

Thread

[PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() zijun_hu <zijun_hu@zoho.com> - 2016-09-21 06:30 +0200
  Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() David Rientjes <rientjes@google.com> - 2016-09-21 23:20 +0200
    Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() zijun_hu <zijun_hu@zoho.com> - 2016-09-22 00:40 +0200
      Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() David Rientjes <rientjes@google.com> - 2016-09-22 00:50 +0200
        Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() David Rientjes <rientjes@google.com> - 2016-09-22 01:20 +0200
          Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() zijun_hu <zijun_hu@zoho.com> - 2016-09-22 02:00 +0200
        Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() zijun_hu <zijun_hu@zoho.com> - 2016-09-22 01:20 +0200
  Re: [RFC PATCH 1/5] mm/vmalloc.c: correct a few logic error for  __insert_vmap_area() zijun_hu <zijun_hu@zoho.com> - 2016-09-22 03:40 +0200

csiph-web