Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488380

Re: [PATCH] x86: fix kdump, cleanup aborted E820_PRAM max_pfn manipulation

Show all headers | View raw

Dan Williams <dan.j.williams@intel.com> writes:

> In commit ec776ef6bbe1 "x86/mm: Add support for the non-standard
> protected e820 type" Christoph references the original patch I wrote
> implementing pmem support.  The intent of the 'max_pfn' changes in that
> commit were to enable persistent memory ranges to be covered by the
> struct page memmap by default.  However, that approach was abandoned
> when Christoph ported the patches [1], and that functionality has since
> been replaced by devm_memremap_pages().
>
> In the meantime, this max_pfn manipulation is confusing kdump [2] that
> assumes that everything covered by the max_pfn is "System RAM".  This
> results in kdump hanging or crashing.

That was my assumption, I'm not certain that the kdump code is assuming
the pmem region is usable as RAM.  The end result is a hung kdump
kernel.

> [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-March/000348.html
> [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1351098
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Boaz Harrosh <boaz@plexistor.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Reported-by: Zhang Yi <yizhan@redhat.com>
> Reported-by: Jeff Moyer <jmoyer@redhat.com>
> Tested-by: Zhang Yi <yizhan@redhat.com>

I actually did the testing.  You can leave that line as is, though, as
I'm sure Yi will also test it.  :)

> Fixes: ec776ef6bbe1 ("x86/mm: Add support for the non-standard protected e820 type")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

Thanks, Dan!

-Jeff

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: fix kdump,  cleanup aborted E820_PRAM max_pfn manipulation Dan Williams <dan.j.williams@intel.com> - 2016-09-21 22:00 +0200
  Re: [PATCH] x86: fix kdump, cleanup aborted E820_PRAM max_pfn manipulation Jeff Moyer <jmoyer@redhat.com> - 2016-09-21 22:30 +0200
  [tip:x86/boot] x86/boot: Fix kdump, cleanup aborted E820_PRAM  max_pfn manipulation tip-bot for Dan Williams <tipbot@zytor.com> - 2016-09-22 14:10 +0200

csiph-web