Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488385
| From | Bin Liu <b-liu@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usb: musb: fix error handling message in probe |
| Date | 2016-09-21 22:50 +0200 |
| Message-ID | <sjWCS-5j1-23@gated-at.bofh.it> (permalink) |
| References | <si9NT-2t7-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
On Sat, Sep 17, 2016 at 12:21:25AM +0200, Arnd Bergmann wrote:
> We print an error message when platform_device_register_full()
> fails, but the initialization of the argument has been removed,
> as shown in this warning:
>
> drivers/usb/musb/da8xx.c: In function 'da8xx_probe':
> drivers/usb/musb/da8xx.c:521:3: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This modifies the function to assign the return code before
> checking it, and does uses the same method in the check for
> usb_phy_generic_register() as well.
>
> Fixes: 947c49afe41f ("usb: musb: da8xx: Remove mach code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. Thanks.
(Added 'da8xx:' prefix in the commit subject)
Regards,
-Bin.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] usb: musb: fix error handling message in probe Arnd Bergmann <arnd@arndb.de> - 2016-09-17 00:30 +0200 Re: [PATCH] usb: musb: fix error handling message in probe Bin Liu <b-liu@ti.com> - 2016-09-21 22:50 +0200
csiph-web