Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488368

[PATCH] ata: Replace BUG() with BUG_ON().

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Harman Kalra <harman4linux@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] ata: Replace BUG() with BUG_ON().
Date Wed, 21 Sep 2016 22:10:02 +0200
Message-ID <sjW0a-545-3@gated-at.bofh.it> (permalink)
X-Original-To b.zolnierkie@samsung.com, tj@kernel.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=qKgDUCIS9xKaNAqPVgTogK51xUQZLgJN9zSNcvzTIhg=; b=RiDbLwB3K2BWUfBAoHDmTCMUBTjg3WEkmqA4PZT4yV4tbhM+P0MPcYwHwVns+Ddh3l deTAYKhdgMFqJJ0bAVMJW8Lf9TWDerkWXtrt8NiAi6HrgTp4ZGFrqNblRIEEya11mUgA HxwUI/fiiiTA+RAuU3m2mWq2HLjmooAL8XKVQS8LBBEUaSBf1BDU6qQUya5VdEwkliE4 g7o0+6n1dFswWxOmEZy8CGPP99ctxbp07WVZ821aAX9ldozubTxybpsc6kl7ZdLtBSYU 2mClf3VMprvQTOfUNAwtOS+iafQlvptjhQ7NtNRW92FngcgVSetjfrqQjc6hnzcsNrIg jMEA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qKgDUCIS9xKaNAqPVgTogK51xUQZLgJN9zSNcvzTIhg=; b=R0cNrupJsr55wIDDpW9SeUNjWpS35RC/pTDj3bAgXztJ0Ihutf8CV0ft03ewkt401U nud0MMsZgoj0dbI2ILbsVT4l6CWSO8NJA2T/STBgmfYK09BCjPMObaFnx8JSni7GQYjZ T6CHxmIqkiZcwfadEa2vJkd6Qd0MTZ7pMgmehQwfOUjmz8qTVCUsR0OsRCp1OgZHzLhy 8MDKN6R0RN+JcwgkBAV9FjgZvMjOeJG2DvU/Wsw5Eq1KiGcM7DDKi+KPvYjeMKk62CZH 9Pr0x5WtmPcnM0x2+Ax3c32xlzZZesiJ3eDn0xvSAxmh4XFzPm/9cuu/kXFQHq6q2nRM NGCQ==
X-Gm-Message-State AE9vXwM4U+HdvtdBor7y9UT05BSFPVD4lU0yi79B14cld9E4JmX0bOX2XcgLnJvfRE2Niw==
X-Received by 10.66.54.132 with SMTP id j4mr68394807pap.110.1474488011864; Wed, 21 Sep 2016 13:00:11 -0700 (PDT)
X-Mailer git-send-email 1.7.9.5
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Harman Kalra <harman4linux@gmail.com>
X-Original-Date Thu, 22 Sep 2016 01:29:48 +0530
X-Original-Message-ID <1474487988-4207-1-git-send-email-harman4linux@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1488368

Show key headers only | View raw


Replace BUG() with BUG_ON().
Caught by coccinelle.

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
---
 drivers/ata/pata_octeon_cf.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index 2724595..475a006 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -152,8 +152,7 @@ static void octeon_cf_set_piomode(struct ata_port *ap, struct ata_device *dev)
 		div = 8;
 	T = (int)((1000000000000LL * div) / octeon_get_io_clock_rate());
 
-	if (ata_timing_compute(dev, dev->pio_mode, &timing, T, T))
-		BUG();
+	BUG_ON(ata_timing_compute(dev, dev->pio_mode, &timing, T, T));
 
 	t1 = timing.setup;
 	if (t1)
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] ata: Replace BUG() with BUG_ON(). Harman Kalra <harman4linux@gmail.com> - 2016-09-21 22:10 +0200
  Re: [PATCH] ata: Replace BUG() with BUG_ON(). Tejun Heo <tj@kernel.org> - 2016-09-22 17:50 +0200

csiph-web