Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific register range for ACPI case

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific register range for ACPI case
Date	2016-09-21 21:20 +0200
Message-ID	<sjVdM-4yb-27@gated-at.bofh.it> (permalink)
References	(5 earlier) <sjuQi-4Gm-21@gated-at.bofh.it> <sjyKe-77O-7@gated-at.bofh.it> <sjQnL-1xc-1@gated-at.bofh.it> <sjU81-3SN-7@gated-at.bofh.it> <sjV46-4uN-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 21, 2016 at 11:58:22AM -0700, Duc Dang wrote:
> On Wed, Sep 21, 2016 at 11:04 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > On Wed, Sep 21, 2016 at 03:05:49PM +0100, Lorenzo Pieralisi wrote:

> > The existing x86 practice is to use PNP0C02 devices for this purpose,
> > and I think we should just follow that practice.
> >
> > ...
> >
> > My point is that the hard-coding should not be buried in a driver
> > where it's invisible to the rest of the kernel.  If we hard-code it in
> > a quirk that adds _CRS entries, then the kernel will work just like it
> > would if the firmware had been correct in the first place.  The
> > resource will appear in /sys/devices/pnp*/*/resources and /proc/iomem,
> > and if we ever used _SRS to assign or move ACPI devices, we would know
> > to avoid the bridge resource.
> 
> Are you suggesting to add code similar to functions in
> linux/drivers/pnp/quirks.c to declare/attach the additional resource
> that the host need to have when the resource is not in MCFG table?

Yes, but what I'm suggesting is actually a little stronger.  This has
nothing to do with whether a resource is in the MCFG table or not.

I'm suggesting ACPI firmware should always describe the resource.  If the
firmware is defective and doesn't describe it, we should add a quirk in
pnp/quirks.c to add a resource for it.

Bjorn

Thread

[PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Tomasz Nowicki <tn@semihalf.com> - 2016-09-09 21:30 +0200
  [PATCH V6 4/5] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version Tomasz Nowicki <tn@semihalf.com> - 2016-09-09 21:30 +0200
    Re: [PATCH V6 4/5] PCI: thunder: Enable ACPI PCI controller for  ThunderX pass2.x silicon version Bjorn Helgaas <helgaas@kernel.org> - 2016-09-19 17:50 +0200
      Re: [PATCH V6 4/5] PCI: thunder: Enable ACPI PCI controller for  ThunderX pass2.x silicon version Tomasz Nowicki <tn@semihalf.com> - 2016-09-20 09:10 +0200
        Re: [PATCH V6 4/5] PCI: thunder: Enable ACPI PCI controller for  ThunderX pass2.x silicon version Bjorn Helgaas <helgaas@kernel.org> - 2016-09-20 15:20 +0200
          Re: [PATCH V6 4/5] PCI: thunder: Enable ACPI PCI controller for  ThunderX pass2.x silicon version Tomasz Nowicki <tn@semihalf.com> - 2016-09-21 10:10 +0200
  [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific register range for ACPI case Tomasz Nowicki <tn@semihalf.com> - 2016-09-09 21:30 +0200
    Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-19 20:10 +0200
      Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Tomasz Nowicki <tn@semihalf.com> - 2016-09-20 09:30 +0200
        Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-20 15:40 +0200
          Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-09-20 15:50 +0200
            Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-20 16:10 +0200
              Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-09-20 17:10 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-20 21:20 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-09-21 16:10 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-21 20:10 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Duc Dang <dhdang@apm.com> - 2016-09-21 21:10 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-21 21:20 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Tomasz Nowicki <tn@semihalf.com> - 2016-09-23 13:00 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-09-22 11:50 +0200
                RE: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-09-22 13:20 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-09-22 14:50 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-22 20:40 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-23 00:20 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-09-23 12:20 +0200
                RE: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-09-23 13:00 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Christopher Covington <cov@codeaurora.org> - 2016-09-22 16:30 +0200
                RE: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-09-21 16:20 +0200
                Re: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Bjorn Helgaas <helgaas@kernel.org> - 2016-09-21 21:00 +0200
                RE: [PATCH V6 3/5] PCI: thunder-pem: Allow to probe PEM-specific  register range for ACPI case Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2016-09-22 13:20 +0200
  [PATCH V6 1/5] PCI/ACPI: Extend pci_mcfg_lookup() responsibilities Tomasz Nowicki <tn@semihalf.com> - 2016-09-09 21:30 +0200
  Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Tomasz Nowicki <tn@semihalf.com> - 2016-09-09 21:40 +0200
  Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Bjorn Helgaas <helgaas@kernel.org> - 2016-09-20 21:30 +0200
    Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms cov@codeaurora.org - 2016-09-21 03:20 +0200
      Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Bjorn Helgaas <helgaas@kernel.org> - 2016-09-21 15:20 +0200
        Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Sinan Kaya <okaya@codeaurora.org> - 2016-09-21 16:10 +0200
          Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Sinan Kaya <okaya@codeaurora.org> - 2016-09-21 19:40 +0200
          Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Bjorn Helgaas <helgaas@kernel.org> - 2016-09-21 19:40 +0200
            [PATCHv2] PCI: QDF2432 32 bit config space accessors Christopher Covington <cov@codeaurora.org> - 2016-09-22 00:40 +0200
        Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Christopher Covington <cov@codeaurora.org> - 2016-09-22 00:50 +0200
          Re: [PATCH V6 0/5] ECAM quirks handling for ARM64 platforms Bjorn Helgaas <helgaas@kernel.org> - 2016-09-23 01:10 +0200

csiph-web