Re: [PATCH] arm64, numa: Add cpu_to_node() implementation.

From	Jon Masters <jcm@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64, numa: Add cpu_to_node() implementation.
Date	2016-09-21 18:50 +0200
Message-ID	<sjSSC-2Xx-11@gated-at.bofh.it> (permalink)
References	<sjbNE-Bs-13@gated-at.bofh.it> <sjqMF-1Q1-1@gated-at.bofh.it> <sjrz3-2lw-1@gated-at.bofh.it> <sjtrc-3wU-13@gated-at.bofh.it> <sju3T-43v-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/20/2016 10:12 AM, Hanjun Guo wrote:
> On 09/20/2016 09:38 PM, Robert Richter wrote:
>> On 20.09.16 19:32:34, Hanjun Guo wrote:
>>> On 09/20/2016 06:43 PM, Robert Richter wrote:
>>
>>>> Instead we need to make sure the set_*numa_node() functions are called
>>>> earlier before secondary cpus are booted. My suggested change for that
>>>> is this:
>>>>
>>>>
>>>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>>>> index d93d43352504..952365c2f100 100644
>>>> --- a/arch/arm64/kernel/smp.c
>>>> +++ b/arch/arm64/kernel/smp.c
>>>> @@ -204,7 +204,6 @@ int __cpu_up(unsigned int cpu, struct
>>>> task_struct *idle)
>>>>   static void smp_store_cpu_info(unsigned int cpuid)
>>>>   {
>>>>       store_cpu_topology(cpuid);
>>>> -    numa_store_cpu_info(cpuid);
>>>>   }
>>>>
>>>>   /*
>>>> @@ -719,6 +718,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>>>>               continue;
>>>>
>>>>           set_cpu_present(cpu, true);
>>>> +        numa_store_cpu_info(cpu);
>>>>       }
>>>>   }
>>>
>>> We tried a similar approach which add numa_store_cpu_info() in
>>> early_map_cpu_to_node(), and remove it from smp_store_cpu_info,
>>> but didn't work for us, we will try your approach to see if works.
> 
> And it works :)

Great. I'm curious for further (immediate) feedback on David's updated
patch in the other thread due to some time sensitive needs on our end.

Jon.



-- 
Computer Architect | Sent from my Fedora powered laptop

Thread

[PATCH] arm64, numa: Add cpu_to_node() implementation. David Daney <ddaney.cavm@gmail.com> - 2016-09-19 20:50 +0200
  Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2016-09-20 06:50 +0200
  Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Yisheng Xie <xieyisheng1@huawei.com> - 2016-09-20 12:00 +0200
  Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Hanjun Guo <hanjun.guo@linaro.org> - 2016-09-20 12:10 +0200
  Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Robert Richter <rric@kernel.org> - 2016-09-20 12:50 +0200
    Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Mark Rutland <mark.rutland@arm.com> - 2016-09-20 13:20 +0200
    Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Hanjun Guo <hanjun.guo@linaro.org> - 2016-09-20 13:40 +0200
      Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Robert Richter <rric@kernel.org> - 2016-09-20 15:40 +0200
        Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Hanjun Guo <hanjun.guo@linaro.org> - 2016-09-20 16:20 +0200
          Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. Jon Masters <jcm@redhat.com> - 2016-09-21 18:50 +0200
    Re: [PATCH] arm64, numa: Add cpu_to_node() implementation. David Daney <ddaney.cavm@gmail.com> - 2016-09-20 20:00 +0200

csiph-web