Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488109

Re: [PATCH 47/61] perf c2c report: Add cacheline browser

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 47/61] perf c2c report: Add cacheline browser
Date 2016-09-21 15:00 +0200
Message-ID <sjPi2-Ff-25@gated-at.bofh.it> (permalink)
References <sj6Eh-5Vj-3@gated-at.bofh.it> <sj6Ei-5Vj-41@gated-at.bofh.it> <sjzGh-7MY-7@gated-at.bofh.it> <sjL4J-6Cq-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote:
> On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote:
> > On Mon, 19 Sep 2016 15:09:56 +0200
> > Jiri Olsa <jolsa@kernel.org> wrote:
> > 
> > > +	/* reset abort key so that it can get Ctrl-C as a key */
> > > +	SLang_reset_tty();
> > > +	SLang_init_tty(0, 0, 0);
> > 
> > this fails to build on systems without slang:
> > 
> >   CC       builtin-c2c.o
> > builtin-c2c.c: In function ‘perf_c2c__browse_cacheline’:
> > builtin-c2c.c:2211:2: error: implicit declaration of function ‘SLang_reset_tty’ [-Werror=implicit-function-declaration]
> >   SLang_reset_tty();
> 
> will fix, thanks

fixed branch pushed in perf/c2c_v4

jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 47/61] perf c2c report: Add cacheline browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  Re: [PATCH 47/61] perf c2c report: Add cacheline browser Kim Phillips <kim.phillips@arm.com> - 2016-09-20 22:20 +0200
    Re: [PATCH 47/61] perf c2c report: Add cacheline browser Jiri Olsa <jolsa@redhat.com> - 2016-09-21 10:30 +0200
      Re: [PATCH 47/61] perf c2c report: Add cacheline browser Jiri Olsa <jolsa@redhat.com> - 2016-09-21 15:00 +0200
        Re: [PATCH 47/61] perf c2c report: Add cacheline browser Kim Phillips <kim.phillips@arm.com> - 2016-09-21 21:40 +0200

csiph-web