Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get added to the state

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Mike Lothian <mike@fireburn.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get added to the state
Date	Wed, 21 Sep 2016 13:40:02 +0200
Message-ID	<sjO2C-8rI-9@gated-at.bofh.it> (permalink)
References	<s7fah-5wE-3@gated-at.bofh.it> <s7fai-5wE-25@gated-at.bofh.it> <sjyhb-6IL-15@gated-at.bofh.it> <sjJFE-5Ct-13@gated-at.bofh.it>
X-Original-To	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=fireburn-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4qJzQmLJwSJpS1t2pZcndNZzQQzBQy+5xF8iXYwTgYE=; b=l8YNaWbpPTsH51S4s2K85Cjn8qXjknmfWS4772UxiR7Fb/DOE2uBK5Y/HJtq/FYNxW M0GFBJGU1J590P59vT40pATetCpyIgSa9xPVx6FGcRyMJHLj1E41+znZp3f9ABKTIAwv yF7muB7GRsFlMe11aaWS6fPFlPyImRLsSynSCnrc1RoiVOtVdERK+EHwfq5OqOop0tw1 EUi2L2z2QJJWEVPtBsqpztxyuV+0bSsbRox39baDQCYu773Yq8hbegyE3jEjlJf8Puxq JXVIhWna3fFOBZx/XlFJR6QuHA72v7zvXk6P2SqxfW+JEdz9KnxCJ4cNazqwZS+UcWmr Al+g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4qJzQmLJwSJpS1t2pZcndNZzQQzBQy+5xF8iXYwTgYE=; b=Lgb3Sybix4Ss8xheXzCW7wyf5h6sbpYqppnprNjoDWd4H3zeZUq1cEIbjzPtXCSTUM u26nXN3vaEeFEzRKrsydCOKA3bYa4ZPGju4sBIS9r/efvZykfHjlnhUEnD7UcVgT8Odw e5L4Hvh5pmNLtzRa4MKr/Kr/q6Vx55mD+LljmCtlQ+Bml2nBVVXyrTT7LbvKK5zxlKi+ s7RcM2v+ghX0IBDDlznlROzRy/Zq9Puelvv4qlek2GX3rWMKZDDI6cQ5jdSUomhnuSqA 1jO2aTY7qnjxcJB2VTjwB5kEQxsvT7rhnszXXN2hjwNBgo2QfQQGI8jQD/c9aRWTtUM8 l0SA==
X-Gm-Message-State	AE9vXwOZf6eNIfDobJnKNAcuCL7s0STpB32eNFPPhL7jleVt9oKUB/CZPKEYFU7q+yi1B1f1/4f01VhzURF6gw==
X-Received	by 10.28.187.4 with SMTP id l4mr2616712wmf.124.1474457704957; Wed, 21 Sep 2016 04:35:04 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	quoted-printable
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Lyude <cpaul@redhat.com>, intel-gfx@lists.freedesktop.org, Ville Syrjälä <ville.syrjala@linux.intel.com>, Matt Roper <matthew.d.roper@intel.com>, Radhakrishna Sripada <radhakrishna.sripada@intel.com>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, stable@vger.kernel.org, Daniel Vetter <daniel.vetter@intel.com>
X-Original-Date	Wed, 21 Sep 2016 12:34:44 +0100
X-Original-Message-ID	<CAHbf0-H29EeBt9e0zKpbgbM4-AG7L1nP+N7Lf=4UZp3e6R-G2A@mail.gmail.com>
X-Original-References	<1471463761-26796-1-git-send-email-cpaul@redhat.com> <1471463761-26796-6-git-send-email-cpaul@redhat.com> <CAHbf0-HOLeg6p3K=df3eOk0nuu-FcR63VkMUVUSFKnK4=SJJ5g@mail.gmail.com> <c0ee1dc0-ca47-9d0c-6def-a9a0f1921e62@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1488054

Show key headers only | View raw

I've raised https://bugs.freedesktop.org/show_bug.cgi?id=97888 I'll
attach the info you requested once I get back to my machine

On 21 September 2016 at 07:56, Maarten Lankhorst
<maarten.lankhorst@linux.intel.com> wrote:
> Hey,
>
> Op 20-09-16 om 20:45 schreef Mike Lothian:
>> Hi
>>
>> I've bisected back to this commit in the drm-intel-nightly branch
>>
>> 05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
>> commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460
>> Author: Lyude <cpaul@redhat.com>
>> Date:   Wed Aug 17 15:55:57 2016 -0400
>>
>>    drm/i915/skl: Ensure pipes with changed wms get added to the state
>>
>>    If we're enabling a pipe, we'll need to modify the watermarks on all
>>    active planes. Since those planes won't be added to the state on
>>    their own, we need to add them ourselves.
>>
>>    Signed-off-by: Lyude <cpaul@redhat.com>
>>    Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>    Cc: stable@vger.kernel.org
>>    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>    Cc: Daniel Vetter <daniel.vetter@intel.com>
>>    Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>>    Cc: Hans de Goede <hdegoede@redhat.com>
>>    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>    Link: http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com
>>
>> The symptoms I'm seeing look like tearing at the top of the screen and
>> it's especially noticeable in Chrome - reverting this commit makes the
>> issue go away
>>
>> Let me know if you'd like me to raise a bug
> Please do so, it's nice to refer to when making a fix for it.
>
> Could you attach the contents of /sys/kernel/debug/dri/0/i915_ddb_info for working and not-working in it?
>
> ~Maarten

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get  added to the state Mike Lothian <mike@fireburn.co.uk> - 2016-09-20 20:50 +0200
  Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get  added to the state Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-09-21 09:00 +0200
    Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get  added to the state Mike Lothian <mike@fireburn.co.uk> - 2016-09-21 13:40 +0200

csiph-web