Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488003
| From | Joel Stanley <joel@jms.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] ipmi: Fix ioremap error handling in bt-bmc |
| Date | 2016-09-21 12:10 +0200 |
| Message-ID | <sjMDx-7Fo-63@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
devm_ioremap_resource returns ERR_PTR so we can't check for NULL. Signed-off-by: Joel Stanley <joel@jms.id.au> --- drivers/char/ipmi/bt-bmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c index 2e880bf0be26..de64bf1f2f4d 100644 --- a/drivers/char/ipmi/bt-bmc.c +++ b/drivers/char/ipmi/bt-bmc.c @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev) } bt_bmc->base = devm_ioremap_resource(&pdev->dev, res); - if (!bt_bmc->base) - return -ENOMEM; + if (IS_ERR(bt_bmc->base)) + return PTR_ERR(bt_bmc->base); mutex_init(&bt_bmc->mutex); init_waitqueue_head(&bt_bmc->queue); -- 2.9.3
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] ipmi: Fix ioremap error handling in bt-bmc Joel Stanley <joel@jms.id.au> - 2016-09-21 12:10 +0200
Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc Cédric Le Goater <clg@kaod.org> - 2016-09-21 17:10 +0200
Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc Corey Minyard <minyard@acm.org> - 2016-09-21 18:40 +0200
csiph-web