Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1487916
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter |
| Date | 2016-09-21 10:50 +0200 |
| Message-ID | <sjLo5-6IT-9@gated-at.bofh.it> (permalink) |
| References | <sjqD0-1My-7@gated-at.bofh.it> <sjtUd-3X2-39@gated-at.bofh.it> <sjIzT-4Vo-5@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Wed, Sep 21, 2016 at 07:48:35AM +0200, Wolfram Sang wrote:
> On Tue, Sep 20, 2016 at 04:59:25PM +0300, Mika Westerberg wrote:
> > When enumerating I2C devices connected to an I2C adapter we scan the whole
> > namespace (as it is possible to have devices anywhere in that namespace,
> > not just below the I2C adapter device) and add each found device to the I2C
> > bus in question.
> >
> > Now after commit 525e6fabeae2 ("i2c / ACPI: add support for ACPI
> > reconfigure notifications") checking of the adapter handle to the one found
> > in the I2cSerialBus() resource was moved to happen after resources of the
> > I2C device has been parsed. This means that if the I2cSerialBus() resource
> > points to an adapter that does not exists in the system we still parse
> > those resources. This is problematic in particular because
> > acpi_dev_resource_interrupt() tries to configure GSI if the device also has
> > an Interrupt() resource. Failing to do that results errrors like this to be
> > printed on the console:
> >
> > [ 10.409490] ERROR: Unable to locate IOAPIC for GSI 37
> >
> > To fix this we pass the I2C adapter to i2c_acpi_get_info() and make sure
> > the handle matches the one in the I2cSerialBus() resource before doing
> > anything else to the device.
> >
> > Reported-and-tested-by: Nicolai Stange <nicstange@gmail.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Considering this for for-current. So shall we add:
>
> Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications")
>
> ?
Yes please :)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-19 11:00 +0200
Re: [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-19 15:20 +0200
Re: [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices Nicolai Stange <nicstange@gmail.com> - 2016-09-19 16:00 +0200
Re: [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-20 10:00 +0200
[PATCH] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-20 10:10 +0200
Re: [PATCH] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Nicolai Stange <nicstange@gmail.com> - 2016-09-20 12:40 +0200
Re: [PATCH] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-20 12:50 +0200
[PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-20 16:10 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Nicolai Stange <nicstange@gmail.com> - 2016-09-20 20:50 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 07:50 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-21 10:50 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Wolfram Sang <wsa@the-dreams.de> - 2016-09-21 18:20 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-22 11:00 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Wolfram Sang <wsa@the-dreams.de> - 2016-09-22 11:00 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-22 11:30 +0200
Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Wolfram Sang <wsa@the-dreams.de> - 2016-09-22 20:30 +0200
csiph-web